You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 15:40:31 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3003: Fix SQL planner bug when resolving columns with same name as a relation
andygrove opened a new pull request, #3003:
URL: https://github.com/apache/arrow-datafusion/pull/3003
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/3002
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Improve logic for determining if a compound identifier is referencing a column or an indexed field
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3003: Fix SQL planner bug when resolving columns with same name as a relation
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3003:
URL: https://github.com/apache/arrow-datafusion/pull/3003#issuecomment-1201913829
Benchmark runs are scheduled for baseline = 55a12869f32644ed87d69d9b7617372db5103fb8 and contender = e23925c96c97139d101719fa7a456088eeed6ae9. e23925c96c97139d101719fa7a456088eeed6ae9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fb9513c2f5f24a788fa60ad399b99073...3fa1868e4b364273beecb7ca7e123026/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e8f162aa14d949be94928a628d310ac5...20c85fc3421c40f0998172ea96081095/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/332aaeb4da1945bdaa03c27aaa8e899f...5f057cc1d7d54349a8b4068ecdc141d7/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/87191b9d90d64393ac73e79c33cd59c1...c0193ba96822493a852e8cd4ebaeacfe/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #3003: Fix SQL planner bug when resolving columns with same name as a relation
Posted by GitBox <gi...@apache.org>.
yjshen merged PR #3003:
URL: https://github.com/apache/arrow-datafusion/pull/3003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3003: Fix SQL planner bug when resolving columns with same name as a relation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3003:
URL: https://github.com/apache/arrow-datafusion/pull/3003#issuecomment-1201440707
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3003](https://codecov.io/gh/apache/arrow-datafusion/pull/3003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f84746) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/c7fa789e85025a631ed634881e60c1ed71e8d269?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7fa789) will **increase** coverage by `0.02%`.
> The diff coverage is `96.87%`.
```diff
@@ Coverage Diff @@
## master #3003 +/- ##
==========================================
+ Coverage 85.81% 85.83% +0.02%
==========================================
Files 282 283 +1
Lines 51531 51619 +88
==========================================
+ Hits 44219 44309 +90
+ Misses 7312 7310 -2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/sql/src/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3BsYW5uZXIucnM=) | `81.91% <93.75%> (+0.03%)` | :arrow_up: |
| [datafusion/core/tests/sql/intersection.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9pbnRlcnNlY3Rpb24ucnM=) | `100.00% <100.00%> (ø)` | |
| [datafusion/core/tests/sql/joins.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9qb2lucy5ycw==) | `99.32% <100.00%> (+<0.01%)` | :arrow_up: |
| [datafusion/core/tests/sql/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9tb2QucnM=) | `98.26% <100.00%> (ø)` | |
| [datafusion/core/tests/sql/predicates.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9wcmVkaWNhdGVzLnJz) | `100.00% <100.00%> (ø)` | |
| [datafusion/core/tests/sql/parquet.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9wYXJxdWV0LnJz) | `100.00% <0.00%> (ø)` | |
| [...tafusion/core/src/physical\_plan/file\_format/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L21vZC5ycw==) | `97.36% <0.00%> (ø)` | |
| [datafusion/core/tests/sql/parquet\_schema.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9wYXJxdWV0X3NjaGVtYS5ycw==) | `98.79% <0.00%> (ø)` | |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.77% <0.00%> (+0.34%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/arrow-datafusion/pull/3003/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] waitingkuo commented on pull request #3003: Fix SQL planner bug when resolving columns with same name as a relation
Posted by GitBox <gi...@apache.org>.
waitingkuo commented on PR #3003:
URL: https://github.com/apache/arrow-datafusion/pull/3003#issuecomment-1201519868
i added a simple test case here <https://github.com/andygrove/arrow-datafusion/pull/64>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #3003: Fix SQL planner bug when resolving columns with same name as a relation
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3003:
URL: https://github.com/apache/arrow-datafusion/pull/3003#issuecomment-1201657238
> i added a simple test case here [andygrove#64](https://github.com/andygrove/arrow-datafusion/pull/64)
Thank you @waitingkuo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org