You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2023/03/20 03:18:43 UTC
[GitHub] [datasketches-java] leerho opened a new pull request, #435: Found a minor Javadoc vs implementation discrepancy.
leerho opened a new pull request, #435:
URL: https://github.com/apache/datasketches-java/pull/435
This is WRT getQuantiles(int numEvenlySpaced) methods and the implementation of the QuantilesUtil.evenlySpaced(...) method.
The javadocs of the getQuantiles methods (for all quantiles sketches) claimed that a "numEvenlySpaced == 1" was valid, yet the implementation would throw an exception if "numEvenlySpaced < 2".
So I updated the implementation so that the implementation matched the javadocs.
I also updated the relevant quantiles javadocs to reflect that this exception could be thrown.
The only place this QuantilesUtil.evenlySpaced(...) method was used was for these quantiles methods, so no place else in the library used this common method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #435: Found a minor Javadoc vs implementation discrepancy.
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #435:
URL: https://github.com/apache/datasketches-java/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org