Re: [PR] Expose option to set line terminator for CSV writer [arrow-rs]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #9617:
URL: https://github.com/apache/arrow-rs/pull/9617#discussion_r3021860862


##########
arrow-csv/src/writer.rs:
##########
@@ -1027,10 +1057,80 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555,23:46:03,foo
         let mut buffer: Vec<u8> = vec![];
         file.read_to_end(&mut buffer).unwrap();
 
-        assert_eq!(
-            "c1,c2\n00:02,46:17\n00:02,\n",
-            String::from_utf8(buffer).unwrap()
-        );
+        let output = String::from_utf8(buffer).unwrap();
+        assert_eq!(output, "c1,c2\n00:02,46:17\n00:02,\n");
+    }
+
+    #[test]
+    fn test_write_csv_with_lf_terminator() {

Review Comment:
   I am trying to clear up the PR review queue, so I took the liberty of pushing a commit that reduces the test replication and merged up from main



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org