You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/03 08:12:29 UTC
[GitHub] [iotdb] jt2594838 commented on a change in pull request #5157: [IOTDB-2633]Unification of compaction log formats
jt2594838 commented on a change in pull request #5157:
URL: https://github.com/apache/iotdb/pull/5157#discussion_r818393675
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileIdentifier.java
##########
@@ -126,26 +128,27 @@ public static TsFileIdentifier getFileIdentifierFromOldInfoString(String oldInfo
oldInfoString));
}
return new TsFileIdentifier(
- splittedFileInfo[LOGICAL_SG_OFFSET_IN_LOG],
- splittedFileInfo[VIRTUAL_SG_OFFSET_IN_LOG],
- splittedFileInfo[TIME_PARTITION_OFFSET_IN_LOG],
- Boolean.parseBoolean(splittedFileInfo[SEQUENCE_OFFSET_IN_LOG]),
- splittedFileInfo[FILE_NAME_OFFSET_IN_LOG]);
+ splittedFileInfo[LOGICAL_SG_OFFSET_IN_LOG - 1],
+ splittedFileInfo[VIRTUAL_SG_OFFSET_IN_LOG - 1],
+ splittedFileInfo[TIME_PARTITION_OFFSET_IN_LOG - 1],
+ splittedFileInfo[SEQUENCE_OFFSET_IN_LOG + 4].equals("true")
+ || splittedFileInfo[SEQUENCE_OFFSET_IN_LOG + 4].equals("sequence"),
Review comment:
How about assigning these offsets some names like "LOGICAL_SG_OFFSET_IN_LOG_V012=0" in case the offsets change in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org