You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by kevinGodell <gi...@git.apache.org> on 2015/03/05 01:38:34 UTC
[GitHub] flex-sdk pull request: deleted "removed = source.splice(index, 1)[...
GitHub user kevinGodell opened a pull request:
https://github.com/apache/flex-sdk/pull/17
deleted "removed = source.splice(index, 1)[0];"
removed duplicate manipulation of source array which was causing a second item to be unnecessarily removed in function removeItemAt()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinGodell/flex-sdk patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-sdk/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 64bfc91a0581ed9bfd23cd1263753fd2362110c3
Author: Kevin Godell <ke...@gmail.com>
Date: 2015-03-05T00:37:44Z
deleted "removed = source.splice(index, 1)[0];"
removed duplicate manipulation of source array which was causing a second item to be unnecessarily removed in function removeItemAt()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flex-sdk pull request: deleted "removed = source.splice(index, 1)[...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flex-sdk/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] flex-sdk pull request: deleted "removed = source.splice(index, 1)[...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I wrote a whoel lot of flex unit test a while ago for Array Collection and related classes, I've not looked at them in a while but it might help.
http://people.apache.org/~jmclean/ArrayCollectionTests.fxp
Thanks,
Justin
Re: [GitHub] flex-sdk pull request: deleted "removed =
source.splice(index, 1)[...
Posted by Mihai Chira <mi...@gmail.com>.
Maybe these changes are a good opportunity for a unit test for the
affected functions in ArrayList?
If no one gets to it till then, I can try to write one late next week.
On 9 March 2015 at 07:39, piotrz <pi...@gmail.com> wrote:
> Hi Kevin,
>
> I've just pushed your changes. It sounds like this line was really unneeded.
>
> Thanks for catching it!
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/GitHub-flex-sdk-pull-request-deleted-removed-source-splice-index-1-tp45401p45460.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [GitHub] flex-sdk pull request: deleted "removed =
source.splice(index, 1)[...
Posted by piotrz <pi...@gmail.com>.
Hi Kevin,
I've just pushed your changes. It sounds like this line was really unneeded.
Thanks for catching it!
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/GitHub-flex-sdk-pull-request-deleted-removed-source-splice-index-1-tp45401p45460.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [GitHub] flex-sdk pull request: deleted "removed =
source.splice(index, 1)[...
Posted by "kevin.godell" <ke...@gmail.com>.
ArrayList.as was broken recently due to an improvement. Can somebody with
write access merge this pull request [1] to remove line 532 from [2]
The problem created is that 2 items get removed when using
removeItemAt(index) due to line 532.
[1] https://github.com/apache/flex-sdk/pull/17
[2]
https://github.com/apache/flex-sdk/blob/develop/frameworks/projects/apache/src/org/apache/flex/collections/ArrayList.as
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/GitHub-flex-sdk-pull-request-deleted-removed-source-splice-index-1-tp45401p45454.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.