You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/20 21:00:52 UTC

[GitHub] [incubator-seatunnel] GezimSejdiu opened a new pull request, #1717: [fix][doc] Fix kubernetes.mdx FlinkDeployment yaml validation

GezimSejdiu opened a new pull request, #1717:
URL: https://github.com/apache/incubator-seatunnel/pull/1717

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   This PR fixes / validate `seatunnel-flink.yaml` due to the mel-formatted yaml file (introduced via https://github.com/apache/incubator-seatunnel/pull/1714 when removing spaces -- issue with site builder). While applying the resource you will get (if you just follow the steps and copy the content shown on the documentation): 
   ```console
   ➜  seatunnel kubectl apply -f seatunnel-flink.yaml
   error: error validating "seatunnel-flink.yaml": error validating data: [ValidationError(FlinkDeployment): unknown field "flinkConfiguration" in org.apache.flink.v1alpha1.FlinkDeployment, ....
   ``` 
   As we aim to provide self-contained documentation (which allows users to just follow the steps provided on our documentation) we should also validate the yaml file.
   
   Thanks in advance for your time.
   
   Best regards, 
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1717: [fix][doc] Fix kubernetes.mdx FlinkDeployment yaml validation

Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1717:
URL: https://github.com/apache/incubator-seatunnel/pull/1717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org