You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/23 06:26:52 UTC
Review Request 59482: Added a new sorter test case,
`HierarchicalIterationOrder`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59482/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, James Peach, Michael Park, and Jiang Yan Xu.
Repository: mesos
Description
-------
This behavior is covered by existing test cases to an extent, but some
additional test coverage seems warranted.
Diffs
-----
src/tests/sorter_tests.cpp 2389664df401a4579d7a7a218d552d1d1bec5536
Diff: https://reviews.apache.org/r/59482/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 59482: Added a new sorter test case,
`HierarchicalIterationOrder`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59482/#review175901
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On May 23, 2017, 1:15 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59482/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 1:15 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, James Peach, Michael Park, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This behavior is covered by existing test cases to an extent, but some
> additional test coverage seems warranted.
>
>
> Diffs
> -----
>
> src/tests/sorter_tests.cpp 2389664df401a4579d7a7a218d552d1d1bec5536
>
>
> Diff: https://reviews.apache.org/r/59482/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59482: Added a new sorter test case,
`HierarchicalIterationOrder`.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59482/
-----------------------------------------------------------
(Updated May 23, 2017, 8:15 p.m.)
Review request for mesos, Benjamin Mahler, James Peach, Michael Park, and Jiang Yan Xu.
Changes
-------
Add comment describing test.
Repository: mesos
Description
-------
This behavior is covered by existing test cases to an extent, but some
additional test coverage seems warranted.
Diffs (updated)
-----
src/tests/sorter_tests.cpp 2389664df401a4579d7a7a218d552d1d1bec5536
Diff: https://reviews.apache.org/r/59482/diff/2/
Changes: https://reviews.apache.org/r/59482/diff/1-2/
Testing
-------
`make check`
Thanks,
Neil Conway