You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2015/11/24 07:01:53 UTC

mina-sshd git commit: Builder: suppress heap pollution vararg warning

Repository: mina-sshd
Updated Branches:
  refs/heads/master 2867cbe67 -> 7a59e4d52


Builder: suppress heap pollution vararg warning


Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/7a59e4d5
Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/7a59e4d5
Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/7a59e4d5

Branch: refs/heads/master
Commit: 7a59e4d523b5f0e30b057e078be073a2d5f89396
Parents: 2867cbe
Author: Alon Bar-Lev <al...@gmail.com>
Authored: Tue Nov 24 08:01:35 2015 +0200
Committer: Lyor Goldstein <lg...@vmware.com>
Committed: Tue Nov 24 08:01:35 2015 +0200

----------------------------------------------------------------------
 pom.xml                                                           | 2 ++
 .../main/java/org/apache/sshd/common/util/closeable/Builder.java  | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/7a59e4d5/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 4821880..68cd30b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -802,7 +802,9 @@
                     <source>${javac.source}</source>
                     <target>${javac.target}</target>
                     <compilerArgument>-g</compilerArgument>
+						<!-- see http://www.javaworld.com/article/2073587/javac-s(dashdash)xlint-options.html -->
                     <compilerArgument>-Xlint:-serial</compilerArgument>
+                    <compilerArgument>-Xlint:unchecked</compilerArgument>
                 </configuration>
             </plugin>
             <plugin>

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/7a59e4d5/sshd-core/src/main/java/org/apache/sshd/common/util/closeable/Builder.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/util/closeable/Builder.java b/sshd-core/src/main/java/org/apache/sshd/common/util/closeable/Builder.java
index 375159a..d857ec0 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/util/closeable/Builder.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/util/closeable/Builder.java
@@ -62,7 +62,8 @@ public final class Builder implements ObjectBuilder<Closeable> {
     }
 
     @SuppressWarnings("rawtypes")
-    public <T extends SshFuture> Builder when(@SuppressWarnings("unchecked") SshFuture<T>... futures) {
+    @SafeVarargs
+    public final <T extends SshFuture> Builder when(@SuppressWarnings("unchecked") SshFuture<T>... futures) {
         return when(Arrays.asList(futures));
     }