[GitHub] [druid] suneet-s commented on a change in pull request #10253: Allow forceLimitPushDown in SQL

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #10253:
URL: https://github.com/apache/druid/pull/10253#discussion_r467973549



##########
File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQuery.java
##########
@@ -121,6 +120,10 @@ public static Builder builder()
   @Nullable
   private final DateTime universalTimestamp;
 
+  private final boolean canPushDownLimit;
+  @Nullable
+  private Boolean forceLimitPushDown;

Review comment:
       Can we default to false instead of making this nullable?
   
   ```suggestion
     private boolean forceLimitPushDown;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org