You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/21 13:03:06 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #6795:
Add HTTP Basic Auth for Druid (Issue #4776)
codecov-io edited a comment on issue #6795: Add HTTP Basic Auth for Druid (Issue #4776)
URL: https://github.com/apache/incubator-superset/pull/6795#issuecomment-459520573
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=h1) Report
> Merging [#6795](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/47f42ed351964230c77611b215466eea115e6456?src=pr&el=desc) will **increase** coverage by `0.61%`.
> The diff coverage is `44.44%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6795/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6795 +/- ##
==========================================
+ Coverage 63.84% 64.45% +0.61%
==========================================
Files 421 422 +1
Lines 20445 20573 +128
Branches 2218 2250 +32
==========================================
+ Hits 13053 13261 +208
+ Misses 7260 7185 -75
+ Partials 132 127 -5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `66.21% <ø> (-1.37%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.51% <44.44%> (-0.21%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `26.31% <0%> (-68.93%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `22.4% <0%> (-67.6%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `68.57% <0%> (-20.91%)` | :arrow_down: |
| [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `35.71% <0%> (-12.57%)` | :arrow_down: |
| [...erset/assets/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGF0YXNvdXJjZXMuanM=) | `57.14% <0%> (-9.53%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvZHJhZ0Ryb3BwYWJsZUNvbmZpZy5qcw==) | `29.16% <0%> (-5.84%)` | :arrow_down: |
| [...ts/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWIuanN4) | `66.66% <0%> (-5.75%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `67.58% <0%> (-5.55%)` | :arrow_down: |
| ... and [130 more](https://codecov.io/gh/apache/incubator-superset/pull/6795/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=footer). Last update [47f42ed...1c253a4](https://codecov.io/gh/apache/incubator-superset/pull/6795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org