You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by shahidki31 <gi...@git.apache.org> on 2018/09/22 13:56:39 UTC

[GitHub] spark pull request #22525: [SPARK-25503] Total task message in stage page is...

GitHub user shahidki31 opened a pull request:

    https://github.com/apache/spark/pull/22525

    [SPARK-25503] Total task message in stage page is ambiguous

    ## What changes were proposed in this pull request?
    Test steps : 
       1) bin/spark-shell --conf spark.ui.retainedTasks=10
       2) val rdd = sc.parallelize(1 to 1000, 1000)
      3)  rdd.count
    
    Stage page tab in the UI will display 10 tasks, but display message is wrong. It should reverse.
     
    **Before fix :** 
    ![webui_1](https://user-images.githubusercontent.com/23054875/45917921-8926d800-be9c-11e8-8da5-3998d07e3ccc.jpg)
    
    **After fix**
    ![spark_web_ui2](https://user-images.githubusercontent.com/23054875/45917935-b4112c00-be9c-11e8-9d10-4fcc8e88568f.jpg)
    
    ## 
    How was this patch tested?
    
    Manually tested
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shahidki31/spark SparkUI

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22525
    
----
commit b224a31718b3a5c6ce8754322b1e7d2dd364ac14
Author: Shahid <sh...@...>
Date:   2018-09-22T09:58:35Z

    [SPARK-25503] Total task message in stage page is ambiguous

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503] Total task message in stage page is ambigu...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96523/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22525: [SPARK-25503][WEBUI] Total task message in stage ...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22525#discussion_r219715130
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -132,7 +132,7 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
         val totalTasksNumStr = if (totalTasks == storedTasks) {
           s"$totalTasks"
         } else {
    -      s"$storedTasks, showing ${totalTasks}"
    +      s"$totalTasks, showing $storedTasks"
    --- End diff --
    
    Could you update the title to `[SPARK-25503][CORE][WEBUI] ...`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503] Total task message in stage page is ambigu...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][WEBUI] Total task message in stage page is...

Posted by shahidki31 <gi...@git.apache.org>.

Github user shahidki31 commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    cc @vanzin 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Merged to master/branch-2.4/branch-2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    @shahidki31 . Someone seems to take care of it. This will be merged today after Jenkins passes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by shahidki31 <gi...@git.apache.org>.

Github user shahidki31 commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    seems Jenkins is down again. @SparkQA Test this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by shahidki31 <gi...@git.apache.org>.

Github user shahidki31 commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Hi @dongjoon-hyun , seems Jenkins is down. could you please ask for test again?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    **[Test build #96523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96523/testReport)** for PR 22525 at commit [`b224a31`](https://github.com/apache/spark/commit/b224a31718b3a5c6ce8754322b1e7d2dd364ac14).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][WEBUI] Total task message in stage page is...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    ok to test.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22525: [SPARK-25503][CORE][WEBUI]Total task message in s...

Posted by shahidki31 <gi...@git.apache.org>.

Github user shahidki31 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22525#discussion_r219726139
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -132,7 +132,7 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
         val totalTasksNumStr = if (totalTasks == storedTasks) {
           s"$totalTasks"
         } else {
    -      s"$storedTasks, showing ${totalTasks}"
    +      s"$totalTasks, showing $storedTasks"
    --- End diff --
    
    Done. Thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503] Total task message in stage page is ambigu...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22525: [SPARK-25503][CORE][WEBUI]Total task message in s...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22525


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    **[Test build #4347 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4347/testReport)** for PR 22525 at commit [`b224a31`](https://github.com/apache/spark/commit/b224a31718b3a5c6ce8754322b1e7d2dd364ac14).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    **[Test build #96523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96523/testReport)** for PR 22525 at commit [`b224a31`](https://github.com/apache/spark/commit/b224a31718b3a5c6ce8754322b1e7d2dd364ac14).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22525: [SPARK-25503][CORE][WEBUI]Total task message in stage pa...

Posted by vanzin <gi...@git.apache.org>.

Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/22525
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org