[jira] Commented: (MYFACES-1290) ServletFacesContextImpl.release() doesn't reset

["Adam Winer (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-1290?page=comments#action_12375466 ] 

Adam Winer commented on MYFACES-1290:
-------------------------------------

A FacesContext instance should not be used at all after a call to release(), and there's no way for an implementation to really consider pooling instances given the FacesContextFactory APIs.  IMO, this is not a bug.

> ServletFacesContextImpl.release() doesn't reset
> -----------------------------------------------
>
>          Key: MYFACES-1290
>          URL: http://issues.apache.org/jira/browse/MYFACES-1290
>      Project: MyFaces Core
>         Type: Bug

>   Components: General
>     Versions: 1.1.1, 1.1.2
>     Reporter: Steve Peterson
>     Priority: Minor

>
> When resetting the FacesContext, the _maximumSeverity field isn't reset.  This causes the getMaximumSeverity() method to provide incorrect results after a release().  I would probably mark this as major if MyFaces pooled ServletFacesContextImpl instances, but they don't seem to be reused.
> Fix is to add the following line to the release() method:
>         _maximumSeverity = null;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira