[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1127: DISPATCH-2048: Added code to clean out the qdr_delivery_cleanup_t on …

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1127:
URL: https://github.com/apache/qpid-dispatch/pull/1127#discussion_r614835424



##########
File path: src/router_core/router_core.c
##########
@@ -258,6 +260,22 @@ void qdr_core_free(qdr_core_t *core)
         link = DEQ_HEAD(core->open_links);
     }
 
+    //
+    // Clean up any qdr_delivery_cleanup_t's that are still left in the core->delivery_cleanup_list
+    //
+    if (DEQ_SIZE(core->delivery_cleanup_list) > 0) {

Review comment:
       I'm confused - this check shouldn't be necessary since if length is zero the loop below will not execute since DEQ_HEAD/cleanup will == 0?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org