You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/12/13 02:29:11 UTC
[GitHub] spark pull request #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test ...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/19960
[SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to HiveOrcQuerySuite
## What changes were proposed in this pull request?
As a follow-up of #19948 , this PR moves the test case and adds comments.
## How was this patch tested?
Pass the Jenkins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-19809-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19960.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19960
----
commit 1d5dd768dbb56a6e84bd0494c55423668895a0ff
Author: Dongjoon Hyun <do...@apache.org>
Date: 2017-12-13T00:54:35Z
[SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to HiveOrcQuerySuite
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19960
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19960
**[Test build #84823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84823/testReport)** for PR 19960 at commit [`a32da5f`](https://github.com/apache/spark/commit/a32da5fdffd0c8d19d9d777864b48f810c0b149e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19960
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84821/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19960
Thank you, @HyukjinKwon and @gatorsmile .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test ...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19960#discussion_r156551601
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ---
@@ -2172,21 +2172,4 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
}
}
}
-
- test("SPARK-19809 NullPointerException on zero-size ORC file") {
--- End diff --
Should we move the test above `SPARK-22267 Spark SQL incorrectly reads ORC files when column order is different` too? I think basically that's also the same instance.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19960
Thanks! Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19960
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19960
**[Test build #84821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84821/testReport)** for PR 19960 at commit [`1d5dd76`](https://github.com/apache/spark/commit/1d5dd768dbb56a6e84bd0494c55423668895a0ff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19960
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19960
**[Test build #84821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84821/testReport)** for PR 19960 at commit [`1d5dd76`](https://github.com/apache/spark/commit/1d5dd768dbb56a6e84bd0494c55423668895a0ff).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19960
Thank you always for review and approval, @HyukjinKwon !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19960
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84823/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19960
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19960#discussion_r156553027
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ---
@@ -2172,21 +2172,4 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
}
}
}
-
- test("SPARK-19809 NullPointerException on zero-size ORC file") {
--- End diff --
Yep. I'll piggy back here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19960: [SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19960
**[Test build #84823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84823/testReport)** for PR 19960 at commit [`a32da5f`](https://github.com/apache/spark/commit/a32da5fdffd0c8d19d9d777864b48f810c0b149e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org