You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Yash Talwar (JIRA)" <xa...@xml.apache.org> on 2005/03/31 23:30:16 UTC
[jira] Created: (XALANJ-2089) Performance degradation in ElemNumber.
Performance degradation in ElemNumber.
--------------------------------------
Key: XALANJ-2089
URL: http://issues.apache.org/jira/browse/XALANJ-2089
Project: XalanJ2
Type: Bug
Environment: Windows 2000
Reporter: Yash Talwar
Assigned to: Yash Talwar
org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Yash Talwar (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=history ]
Yash Talwar updated XALANJ-2089:
--------------------------------
Xalan info: [PatchAvailable]
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Yash Talwar (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=history ]
Yash Talwar updated XALANJ-2089:
--------------------------------
Attachment: XalanJ2089_Patch.txt
The problem is that in 2.6.0 xalan.jar, org.apache.xalan.templates.ElemNumber class make use of an static array.
private static char[] m_alphaCountTable = null;
This array is used to keep information about a resources. However, in situation where locale information can be changed dynamically, this would result an error, becuase this static array would keep cache about resource bundle and would not reflect the dynamic change. To resolve this defect and another potential security bug, Christine Li had changed the code to obtain the resource bundle for every request. This had resulted in bad performance.
The performance hit was seen during a performance testing phase.
I found the source of the problem.
Christine Li has created patch to resolve this issue. I am attaching this patch on behalf of Christine as she is away on vacation.
Brian Minchau had helped in creating this patch. I am assigning Brian as reviewer of this patch.
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Closed: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=all ]
Brian Minchau closed XALANJ-2089:
---------------------------------
Yash, I've taken the liberty of closing this issue for you. Re-open if you need to, but I sure hope you don't do that.
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Fix For: 2.7
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=all ]
Brian Minchau updated XALANJ-2089:
----------------------------------
Fix Version: 2.7
(was: CurrentCVS)
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Fix For: 2.7
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=history ]
Brian Minchau updated XALANJ-2089:
----------------------------------
reviewer: minchau@ca.ibm.com
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Yash Talwar (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=history ]
Yash Talwar resolved XALANJ-2089:
---------------------------------
Resolution: Fixed
Fix Version: CurrentCVS
Patch commited to CVS.
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Fix For: CurrentCVS
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2089) Performance degradation in ElemNumber.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2089?page=comments#action_61963 ]
Brian Minchau commented on XALANJ-2089:
---------------------------------------
The attached patch is really the old code back again, but with alphaCountTable cached in an instance variable, rather than a Class static variable. So its scope is the one XSL transformation. The old static variable caching was cached for all transactions in the same JVM, which has implications in a server environment.
As an instance field it is safe.
I have reviewed and approve the patch.
> Performance degradation in ElemNumber.
> --------------------------------------
>
> Key: XALANJ-2089
> URL: http://issues.apache.org/jira/browse/XALANJ-2089
> Project: XalanJ2
> Type: Bug
> Environment: Windows 2000
> Reporter: Yash Talwar
> Assignee: Yash Talwar
> Attachments: XalanJ2089_Patch.txt
>
> org.apache.xalan.templates.ElemNumber has performance degradation between currentCVS version versus Version 2.6.0 xalan.jar file.
> I have performed some testing to validate this degradation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org