You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "cccs-RyanK (via GitHub)" <gi...@apache.org> on 2023/04/19 14:35:08 UTC
[GitHub] [superset] cccs-RyanK commented on pull request #22168: feat(native-filters): Adhoc dashboard native filters
cccs-RyanK commented on PR #22168:
URL: https://github.com/apache/superset/pull/22168#issuecomment-1514850642
> Cool! Thanks for this feature! Two comments:
>
> 1. The + button feels out of place, I think we can hide it like it's hidden from the chart builder:
> 
>
> 2. I don't think we use the terminology "ad hoc filters" in any user facing copy right now, are there any other names that might make it clear to the user about what the filter does? I'm having trouble naming it, would love any ideas!
Thank you for the feedback @yousoph! I agree with the first point I can remove the plus button for sure. For the name maybe "advanced", "extra", or "custom" filters? Not sure if any of those fit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org