You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/12/23 23:22:01 UTC
Review Request 41697: Fixed a documentation bug in containerizer
internals doc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41697/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jojy Varghese.
Repository: mesos
Description
-------
The current document delves upon the behavior of using the default executor i.e. `mesos-docker-executor` on whether the task has `TaskInfo` set or not. This is slightly confusing as any task in Mesos is specified via the `TaskInfo` protobuf message.
This change corrects this and outlines the difference in behavior on whether the `Task` specifies an executor (custom executor) or specifies a command (command executor).
Diffs
-----
docs/containerizer-internals.md 4386bbda21686b616ccf85db408899fece3680df
Diff: https://reviews.apache.org/r/41697/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41697: Fixed a documentation bug in containerizer
internals doc.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41697/#review111915
-----------------------------------------------------------
Ship it!
Ship It!
- Jojy Varghese
On Dec. 23, 2015, 10:22 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41697/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 10:22 p.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current document delves upon the behavior of using the default executor i.e. `mesos-docker-executor` on whether the task has `TaskInfo` set or not. This is slightly confusing as any task in Mesos is specified via the `TaskInfo` protobuf message.
>
> This change corrects this and outlines the difference in behavior on whether the `Task` specifies an executor (custom executor) or specifies a command (command executor).
>
>
> Diffs
> -----
>
> docs/containerizer-internals.md 4386bbda21686b616ccf85db408899fece3680df
>
> Diff: https://reviews.apache.org/r/41697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41697: Fixed a documentation bug in containerizer
internals doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41697/#review111813
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41697]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 23, 2015, 10:22 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41697/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 10:22 p.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current document delves upon the behavior of using the default executor i.e. `mesos-docker-executor` on whether the task has `TaskInfo` set or not. This is slightly confusing as any task in Mesos is specified via the `TaskInfo` protobuf message.
>
> This change corrects this and outlines the difference in behavior on whether the `Task` specifies an executor (custom executor) or specifies a command (command executor).
>
>
> Diffs
> -----
>
> docs/containerizer-internals.md 4386bbda21686b616ccf85db408899fece3680df
>
> Diff: https://reviews.apache.org/r/41697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41697: Fixed a documentation bug in containerizer
internals doc.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41697/#review112333
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 23, 2015, 10:22 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41697/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 10:22 p.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current document delves upon the behavior of using the default executor i.e. `mesos-docker-executor` on whether the task has `TaskInfo` set or not. This is slightly confusing as any task in Mesos is specified via the `TaskInfo` protobuf message.
>
> This change corrects this and outlines the difference in behavior on whether the `Task` specifies an executor (custom executor) or specifies a command (command executor).
>
>
> Diffs
> -----
>
> docs/containerizer-internals.md 4386bbda21686b616ccf85db408899fece3680df
>
> Diff: https://reviews.apache.org/r/41697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>