You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Vinay (JIRA)" <ji...@apache.org> on 2012/11/24 10:02:57 UTC
[jira] [Created] (BOOKKEEPER-478) Changes from BOOKKEEPER-203
broken capability of including bookkeeper-server jar in hidden package of
BKJM
Vinay created BOOKKEEPER-478:
--------------------------------
Summary: Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM
Key: BOOKKEEPER-478
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-478
Project: Bookkeeper
Issue Type: Bug
Reporter: Vinay
BOOKKEEPER-203 introduced changes to LedgerLayout to include ManagerFactoryClass instead of ManagerFactoryName.
So because of this, BKJM cannot shade the bookkeeper-server jar inside BKJM jar
LAYOUT znode created by BookieServer is not readable by the BKJM as it have classes in hidden packages. (same problem vice versa)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-478) Changes from BOOKKEEPER-203
broken capability of including bookkeeper-server jar in hidden package of
BKJM
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated BOOKKEEPER-478:
-------------------------------------------
Fix Version/s: 4.2.0
> Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM
> ----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-478
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-478
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Vinay
> Fix For: 4.2.0
>
>
> BOOKKEEPER-203 introduced changes to LedgerLayout to include ManagerFactoryClass instead of ManagerFactoryName.
> So because of this, BKJM cannot shade the bookkeeper-server jar inside BKJM jar
> LAYOUT znode created by BookieServer is not readable by the BKJM as it have classes in hidden packages. (same problem vice versa)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-478) Changes from BOOKKEEPER-203
broken capability of including bookkeeper-server jar in hidden package of
BKJM
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503797#comment-13503797 ]
Ivan Kelly commented on BOOKKEEPER-478:
---------------------------------------
Yes, ZK is pulled in through hadoop-common, so it's fine to remove it from the shaded jar. We should go through all the pulled in dependencies to check for cases like this. In any case, this is a HDFS jira really, as the pom.xml in question is there. We don't need to do anything on the bookkeeper side, but we will on the hdfs side once 4.2.0 is released. We'll also need to make changes to take advantage of BOOKKEEPER-208.
> Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM
> ----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-478
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-478
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Vinay
> Fix For: 4.2.0
>
>
> BOOKKEEPER-203 introduced changes to LedgerLayout to include ManagerFactoryClass instead of ManagerFactoryName.
> So because of this, BKJM cannot shade the bookkeeper-server jar inside BKJM jar
> LAYOUT znode created by BookieServer is not readable by the BKJM as it have classes in hidden packages. (same problem vice versa)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-478) Changes from BOOKKEEPER-203
broken capability of including bookkeeper-server jar in hidden package of
BKJM
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503388#comment-13503388 ]
Uma Maheswara Rao G commented on BOOKKEEPER-478:
------------------------------------------------
As per the readMe for the users, I feel this will be a blocker.
Let's remove shade. We remove for ZK as well right? (as Hadoop already including zk jar)
> Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM
> ----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-478
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-478
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Vinay
> Fix For: 4.2.0
>
>
> BOOKKEEPER-203 introduced changes to LedgerLayout to include ManagerFactoryClass instead of ManagerFactoryName.
> So because of this, BKJM cannot shade the bookkeeper-server jar inside BKJM jar
> LAYOUT znode created by BookieServer is not readable by the BKJM as it have classes in hidden packages. (same problem vice versa)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-478) Changes from BOOKKEEPER-203
broken capability of including bookkeeper-server jar in hidden package of
BKJM
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503379#comment-13503379 ]
Ivan Kelly commented on BOOKKEEPER-478:
---------------------------------------
Yup, I've come across this. The simple solution is to just not shade bookkeeper in the bkjm jar. Another solution would be to account for the shading in the configuration, but I think this is unnecessary. Really, what we need to shade is anything that there may be an incompatability with in another hadoop module. I doubt another hadoop module will import bookkeeper, so it's fine to not shade it.
> Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM
> ----------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-478
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-478
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Vinay
> Fix For: 4.2.0
>
>
> BOOKKEEPER-203 introduced changes to LedgerLayout to include ManagerFactoryClass instead of ManagerFactoryName.
> So because of this, BKJM cannot shade the bookkeeper-server jar inside BKJM jar
> LAYOUT znode created by BookieServer is not readable by the BKJM as it have classes in hidden packages. (same problem vice versa)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira