[GitHub] rdhabalia commented on a change in pull request #709: Succeed when unloading namespace bundles not owned by any broker

[gi...@git.apache.org]

rdhabalia commented on a change in pull request #709: Succeed when unloading namespace bundles not owned by any broker
URL: https://github.com/apache/incubator-pulsar/pull/709#discussion_r134347870
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/DestinationLookup.java
 ##########
 @@ -223,8 +223,9 @@ public void lookupDestinationAsync(@PathParam("property") String property, @Path
                                 log.debug("[{}] Lookup result {}", fqdn.toString(), lookupResult);
                             }
 
-                            LookupData lookupData = lookupResult.getLookupData();
-                            if (lookupResult.isRedirect()) {
+                            checkArgument(lookupResult.isPresent());
 
 Review comment:
   instead throwing RuntimeException, shouldn't we fail the `lookupfuture`.?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services