You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Denis Kishenko (JIRA)" <ji...@apache.org> on 2006/10/10 16:37:19 UTC

[jira] Created: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

[classlib][awt][test] java.awt test resources are located in wrong place
------------------------------------------------------------------------

                 Key: HARMONY-1813
                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Denis Kishenko
            Priority: Minor


There are several moments to be fixed
1. Serialization and shape resources necessary for junit test are located in wrong places.
   modules\awt\src\test\api\java\common\java\awt\serialization
   modules\awt\src\test\api\java\common\java\awt\shapes
   modules\awt\src\test\api\java\common\java\awt\geom\serialization
   modules\awt\src\test\api\java\common\java\awt\geom\shapes
2. Tests use TEST_SRC_DIR parameter to find resources.
3. DimensionTest serialization test failed (test excluded).


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Created: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by Mark Hindess <ma...@googlemail.com>.
Denis,

Unfortunately, I missed that you'd uploaded these and sadly I get lots 
of rejects from the new patch now.  I'm still taking a look but a new
patch would be helpful.  I have now assigned the JIRA to myself so I
shouldn't miss any changes to it.

Regards,
 Mark.

On 18 October 2006 at 17:19, "Denis Kishenko" <dk...@gmail.com> wrote:
> Mark, I have updated patch as you suggested week ago. Did you try it?
> 
> 2006/10/10, Mark Hindess <ma...@googlemail.com>:
> >
> > On 10 October 2006 at 19:00, "Denis Kishenko" <dk...@gmail.com> wrote:
> > > Hi committers
> > >
> > > Could someone look at this issue. Because I am going to make another
> > > fix which is depend on this patch.
> >
> > The diff looks like it contains some moves.  In order to keep the
> > history, please submit moves as a recipe (batch/shell script) rather
> > than as part of a diff.
> >
> > Regards,
> >  Mark.
> >
> >
> > > 2006/10/10, Denis Kishenko (JIRA) <ji...@apache.org>:
> > > > [classlib][awt][test] java.awt test resources are located in wrong plac
> e
> > > > -----------------------------------------------------------------------
> -
> > > >
> > > >                 Key: HARMONY-1813
> > > >                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
> > > >             Project: Harmony
> > > >          Issue Type: Bug
> > > >          Components: Classlib
> > > >            Reporter: Denis Kishenko
> > > >            Priority: Minor
> > > >
> > > >
> > > > There are several moments to be fixed
> > > > 1. Serialization and shape resources necessary for junit test are locat
> ed i
> > > n wrong places.
> > > >   modules\awt\src\test\api\java\common\java\awt\serialization
> > > >   modules\awt\src\test\api\java\common\java\awt\shapes
> > > >   modules\awt\src\test\api\java\common\java\awt\geom\serialization
> > > >   modules\awt\src\test\api\java\common\java\awt\geom\shapes
> > > > 2. Tests use TEST_SRC_DIR parameter to find resources.
> > > > 3. DimensionTest serialization test failed (test excluded).
> > > >
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > -
> > > > If you think it was sent incorrectly contact one of the administrators:
>  htt
> > > p://issues.apache.org/jira/secure/Administrators.jspa
> > > > -
> > > > For more information on JIRA, see: http://www.atlassian.com/software/ji
> ra
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Denis M. Kishenko
> > > Intel Middleware Products Division
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> 
> 
> -- 
> Denis M. Kishenko
> Enterprise Solutions Software Division
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: [jira] Created: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by Denis Kishenko <dk...@gmail.com>.
Mark, I have updated patch as you suggested week ago. Did you try it?

2006/10/10, Mark Hindess <ma...@googlemail.com>:
>
> On 10 October 2006 at 19:00, "Denis Kishenko" <dk...@gmail.com> wrote:
> > Hi committers
> >
> > Could someone look at this issue. Because I am going to make another
> > fix which is depend on this patch.
>
> The diff looks like it contains some moves.  In order to keep the
> history, please submit moves as a recipe (batch/shell script) rather
> than as part of a diff.
>
> Regards,
>  Mark.
>
>
> > 2006/10/10, Denis Kishenko (JIRA) <ji...@apache.org>:
> > > [classlib][awt][test] java.awt test resources are located in wrong place
> > > ------------------------------------------------------------------------
> > >
> > >                 Key: HARMONY-1813
> > >                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
> > >             Project: Harmony
> > >          Issue Type: Bug
> > >          Components: Classlib
> > >            Reporter: Denis Kishenko
> > >            Priority: Minor
> > >
> > >
> > > There are several moments to be fixed
> > > 1. Serialization and shape resources necessary for junit test are located i
> > n wrong places.
> > >   modules\awt\src\test\api\java\common\java\awt\serialization
> > >   modules\awt\src\test\api\java\common\java\awt\shapes
> > >   modules\awt\src\test\api\java\common\java\awt\geom\serialization
> > >   modules\awt\src\test\api\java\common\java\awt\geom\shapes
> > > 2. Tests use TEST_SRC_DIR parameter to find resources.
> > > 3. DimensionTest serialization test failed (test excluded).
> > >
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > If you think it was sent incorrectly contact one of the administrators: htt
> > p://issues.apache.org/jira/secure/Administrators.jspa
> > > -
> > > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > >
> > >
> > >
> >
> >
> > --
> > Denis M. Kishenko
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Denis M. Kishenko
Enterprise Solutions Software Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: [jira] Created: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by Mark Hindess <ma...@googlemail.com>.
On 10 October 2006 at 19:00, "Denis Kishenko" <dk...@gmail.com> wrote:
> Hi committers
> 
> Could someone look at this issue. Because I am going to make another
> fix which is depend on this patch.

The diff looks like it contains some moves.  In order to keep the 
history, please submit moves as a recipe (batch/shell script) rather
than as part of a diff.

Regards,
 Mark.


> 2006/10/10, Denis Kishenko (JIRA) <ji...@apache.org>:
> > [classlib][awt][test] java.awt test resources are located in wrong place
> > ------------------------------------------------------------------------
> >
> >                 Key: HARMONY-1813
> >                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
> >             Project: Harmony
> >          Issue Type: Bug
> >          Components: Classlib
> >            Reporter: Denis Kishenko
> >            Priority: Minor
> >
> >
> > There are several moments to be fixed
> > 1. Serialization and shape resources necessary for junit test are located i
> n wrong places.
> >   modules\awt\src\test\api\java\common\java\awt\serialization
> >   modules\awt\src\test\api\java\common\java\awt\shapes
> >   modules\awt\src\test\api\java\common\java\awt\geom\serialization
> >   modules\awt\src\test\api\java\common\java\awt\geom\shapes
> > 2. Tests use TEST_SRC_DIR parameter to find resources.
> > 3. DimensionTest serialization test failed (test excluded).
> >
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators: htt
> p://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see: http://www.atlassian.com/software/jira
> >
> >
> >
> 
> 
> -- 
> Denis M. Kishenko
> Intel Middleware Products Division
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: [jira] Created: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by Denis Kishenko <dk...@gmail.com>.
Hi committers

Could someone look at this issue. Because I am going to make another
fix which is depend on this patch.

Thanks.

2006/10/10, Denis Kishenko (JIRA) <ji...@apache.org>:
> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>            Priority: Minor
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>   modules\awt\src\test\api\java\common\java\awt\serialization
>   modules\awt\src\test\api\java\common\java\awt\shapes
>   modules\awt\src\test\api\java\common\java\awt\geom\serialization
>   modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).
>
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>


-- 
Denis M. Kishenko
Intel Middleware Products Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


[jira] Updated: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by "Denis Kishenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1813?page=all ]

Denis Kishenko updated HARMONY-1813:
------------------------------------

    Attachment: serialization.zip

3. Golden file was damaged, so new was generated. Also .ser extension was added to all serialization golden files.
 
Golden files should be unpacked into
modules\awt\src\test\api\resources


> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>            Priority: Minor
>         Attachments: Resources.diff, serialization.zip
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>    modules\awt\src\test\api\java\common\java\awt\serialization
>    modules\awt\src\test\api\java\common\java\awt\shapes
>    modules\awt\src\test\api\java\common\java\awt\geom\serialization
>    modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by "Denis Kishenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1813?page=all ]

Denis Kishenko updated HARMONY-1813:
------------------------------------

    Attachment: HARMONY-1813-Resources.patch

I made changes as Mark suggested
http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200610.mbox/%3c200610101536.k9AFaTeU024643@d06av02.portsmouth.uk.ibm.com%3e

> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>            Priority: Minor
>         Attachments: HARMONY-1813-Resources.patch, HARMONY-1813-Resources.sh, Resources.diff, serialization.zip
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>    modules\awt\src\test\api\java\common\java\awt\serialization
>    modules\awt\src\test\api\java\common\java\awt\shapes
>    modules\awt\src\test\api\java\common\java\awt\geom\serialization
>    modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1813?page=all ]

Mark Hindess reassigned HARMONY-1813:
-------------------------------------

    Assignee: Mark Hindess

> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: HARMONY-1813-Resources.patch, HARMONY-1813-Resources.sh, HARMONY-1813-Resources.zip, Resources.diff, serialization.zip
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>    modules\awt\src\test\api\java\common\java\awt\serialization
>    modules\awt\src\test\api\java\common\java\awt\shapes
>    modules\awt\src\test\api\java\common\java\awt\geom\serialization
>    modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by "Denis Kishenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1813?page=all ]

Denis Kishenko updated HARMONY-1813:
------------------------------------

    Attachment: HARMONY-1813-Resources.zip

Unpack to modules/awt/src/test/api/resources/serialization/java/awt/

> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>            Priority: Minor
>         Attachments: HARMONY-1813-Resources.patch, HARMONY-1813-Resources.sh, HARMONY-1813-Resources.zip, Resources.diff, serialization.zip
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>    modules\awt\src\test\api\java\common\java\awt\serialization
>    modules\awt\src\test\api\java\common\java\awt\shapes
>    modules\awt\src\test\api\java\common\java\awt\geom\serialization
>    modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by "Denis Kishenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1813?page=all ]

Denis Kishenko updated HARMONY-1813:
------------------------------------

    Attachment: HARMONY-1813-Resources.sh

Run this script from the same place as patch

> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>            Priority: Minor
>         Attachments: HARMONY-1813-Resources.patch, HARMONY-1813-Resources.sh, Resources.diff, serialization.zip
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>    modules\awt\src\test\api\java\common\java\awt\serialization
>    modules\awt\src\test\api\java\common\java\awt\shapes
>    modules\awt\src\test\api\java\common\java\awt\geom\serialization
>    modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1813) [classlib][awt][test] java.awt test resources are located in wrong place

Posted by "Denis Kishenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1813?page=all ]

Denis Kishenko updated HARMONY-1813:
------------------------------------

    Attachment: Resources.diff

1. Resources were moved to 
   modules\awt\src\test\api\resources\serialization
   modules\awt\src\test\api\resources\shapes
As result build.xml and related tests were modified. 

************* Next folders should be deleted ******************
   modules\awt\src\test\api\java\common\java\awt\serialization
   modules\awt\src\test\api\java\common\java\awt\shapes
   modules\awt\src\test\api\java\common\java\awt\geom\serialization
   modules\awt\src\test\api\java\common\java\awt\geom\shapes
   modules\awt\src\test\api\java\common\java\awt\geom\ShapeTest.java (this file is unused)

2. Dependences on TEST_SRC_DIR parameter were removed using ClassLoader.getSystemClassLoader().getResource(...).

> [classlib][awt][test] java.awt test resources are located in wrong place
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-1813
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1813
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>            Priority: Minor
>         Attachments: Resources.diff
>
>
> There are several moments to be fixed
> 1. Serialization and shape resources necessary for junit test are located in wrong places.
>    modules\awt\src\test\api\java\common\java\awt\serialization
>    modules\awt\src\test\api\java\common\java\awt\shapes
>    modules\awt\src\test\api\java\common\java\awt\geom\serialization
>    modules\awt\src\test\api\java\common\java\awt\geom\shapes
> 2. Tests use TEST_SRC_DIR parameter to find resources.
> 3. DimensionTest serialization test failed (test excluded).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira