[GitHub] [airflow] dstandish edited a comment on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

[GitBox <gi...@apache.org>]

dstandish edited a comment on pull request #6850:
URL: https://github.com/apache/airflow/pull/6850#issuecomment-768548513


   @ldacey let me add...
   
   Just going through the process of getting something merged is meaningful and valuable work in itself and this would probably be a nice addition.
   
   But there also remains meaningful creative work for this one.
   
   For example, we need to think through wherther and how to make it so `MsSqlOperator` can optionally use turbodbc. Right now, it will use odbc hook if conn type is `odbc` and original `MsSqlHook` otherwise.  It's possible you could make it so if conn type is `turbodbc` then it uses turbodbc connection.
   
   Or perhaps you might decide it makes more sense to contribute a turbodbc hook, which could be a thin subclass of odbc hook, changing only get_conn.
   
   I never got around to thinking through these decisions, which is partly i never made this pr.
   
   Additionally there is the need to address documentation.
   
   So, you can definitely contribute support for turbodbc without feeling in any way that you appropriated anything.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org