You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/05/04 16:03:14 UTC
[kudu-CR] [java] Adjust Gradle compilation to better support Java 9+
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10307
Change subject: [java] Adjust Gradle compilation to better support Java 9+
......................................................................
[java] Adjust Gradle compilation to better support Java 9+
Uses the --release flag for Java 9+ and adjusts the usage of
the javaCompatibility property to closer match java versioning
going forward.
Change-Id: Ia8e97570004f087fea73785991cb2779d4b70b2c
---
M java/gradle.properties
M java/gradle/compile.gradle
M java/gradle/quality.gradle
3 files changed, 24 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10307/1
--
To view, visit http://gerrit.cloudera.org:8080/10307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8e97570004f087fea73785991cb2779d4b70b2c
Gerrit-Change-Number: 10307
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Adjust Gradle compilation to better support Java 9+
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10307 )
Change subject: [java] Adjust Gradle compilation to better support Java 9+
......................................................................
Patch Set 1: Code-Review+2
So with this patch in, are you able to compile with Java 9?
--
To view, visit http://gerrit.cloudera.org:8080/10307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8e97570004f087fea73785991cb2779d4b70b2c
Gerrit-Change-Number: 10307
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 04 May 2018 17:04:17 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Adjust Gradle compilation to better support Java 9+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10307 )
Change subject: [java] Adjust Gradle compilation to better support Java 9+
......................................................................
[java] Adjust Gradle compilation to better support Java 9+
Uses the --release flag for Java 9+ and adjusts the usage of
the javaCompatibility property to closer match java versioning
going forward.
Change-Id: Ia8e97570004f087fea73785991cb2779d4b70b2c
Reviewed-on: http://gerrit.cloudera.org:8080/10307
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/gradle.properties
M java/gradle/compile.gradle
M java/gradle/quality.gradle
3 files changed, 24 insertions(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8e97570004f087fea73785991cb2779d4b70b2c
Gerrit-Change-Number: 10307
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Adjust Gradle compilation to better support Java 9+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10307 )
Change subject: [java] Adjust Gradle compilation to better support Java 9+
......................................................................
Patch Set 1:
No, there is more work needed. See my post on your ubuntu jira. I am working on the FakeDNs change which is the biggest blocker.
--
To view, visit http://gerrit.cloudera.org:8080/10307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8e97570004f087fea73785991cb2779d4b70b2c
Gerrit-Change-Number: 10307
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 04 May 2018 17:05:22 +0000
Gerrit-HasComments: No