You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/21 06:11:43 UTC

[GitHub] [flink] huwh opened a new pull request, #21354: [FLINK-30084][Runtime] Remove unused method notifyAllocationFailure.

huwh opened a new pull request, #21354:
URL: https://github.com/apache/flink/pull/21354

   
   ## What is the purpose of the change
   
   The methods ResourceActions#notifyAllocationFailure and JobMasterGateway#notifyAllocationFailure are not used and should be removed.
   
   
   ## Brief change log
   Remove ResourceActions#notifyAllocationFailure and JobMasterGateway#notifyAllocationFailure and the related unit tests.
   
   
   ## Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong closed pull request #21354: [FLINK-30084][Runtime] Remove unused method notifyAllocationFailure.

Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #21354: [FLINK-30084][Runtime] Remove unused method notifyAllocationFailure.
URL: https://github.com/apache/flink/pull/21354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21354: [FLINK-30084][Runtime] Remove unused method notifyAllocationFailure.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21354:
URL: https://github.com/apache/flink/pull/21354#issuecomment-1321511902

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "157c1984af79af7af52769b9037a13e824cda211",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "157c1984af79af7af52769b9037a13e824cda211",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 157c1984af79af7af52769b9037a13e824cda211 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org