You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/09/15 00:17:21 UTC
[GitHub] [mynewt-core] benmccrea commented on a change in pull request
#2000: mcu/dialog: define adc pin selections in mcu.h
benmccrea commented on a change in pull request #2000: mcu/dialog: define adc pin selections in mcu.h
URL: https://github.com/apache/mynewt-core/pull/2000#discussion_r324441754
##########
File path: hw/mcu/dialog/da14699/include/mcu/mcu.h
##########
@@ -119,6 +119,28 @@ typedef enum {
#define MCU_GPIO_PORT1(pin) ((1 * 32) + (pin))
#define MCU_DMA_CHAN_MAX 8
+#define MCU_GP_ADC_SEL0 MCU_GPIO_PORT1(9)
Review comment:
@JustineKH I agree with andrzej about the naming. If you will make those changes and reflect the same changes to mynewt_runtime #69 then I think we should get this merged ASAP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services