You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2023/04/27 14:47:51 UTC
[GitHub] [shardingsphere] iamhucong opened a new pull request, #25375: Support BetweenExpression in Projection (#25294)
iamhucong opened a new pull request, #25375:
URL: https://github.com/apache/shardingsphere/pull/25375
Fixes #25294.
Changes proposed in this pull request:
- Support BetweenExpression in Projection
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #25375: Support BetweenExpression in Projection (#25294)
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #25375:
URL: https://github.com/apache/shardingsphere/pull/25375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on a diff in pull request #25375: Support BetweenExpression in Projection (#25294)
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on code in PR #25375:
URL: https://github.com/apache/shardingsphere/pull/25375#discussion_r1179876260
##########
sql-parser/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java:
##########
@@ -1611,6 +1611,11 @@ private ASTNode createProjection(final ProjectionContext ctx, final AliasSegment
result.setAlias(alias);
return result;
}
+ if (projection instanceof BetweenExpression) {
Review Comment:
Okay, I will continue working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #25375: Support BetweenExpression in Projection (#25294)
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #25375:
URL: https://github.com/apache/shardingsphere/pull/25375#discussion_r1179845559
##########
sql-parser/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java:
##########
@@ -1611,6 +1611,11 @@ private ASTNode createProjection(final ProjectionContext ctx, final AliasSegment
result.setAlias(alias);
return result;
}
+ if (projection instanceof BetweenExpression) {
Review Comment:
Hi @iamhucong, can you add sql parser test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org