You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by ocelotpotpie <gi...@git.apache.org> on 2014/12/18 16:49:56 UTC
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
GitHub user ocelotpotpie opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/208
Couchdb 2483 add cors to fauxton
This adds CORS into fauxton in the config section, allowing users to enable and disable CORS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ocelotpotpie/couchdb-fauxton COUCHDB-2483-add-cors-to-fauxton
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit d957324b7799695002ff6b721e2d17664058355b
Author: Christian Hogan <gi...@infliction.org>
Date: 2014-11-28T18:19:13Z
Adding CORS to Fauxton
commit 8e28c014be891159716ab3232015f6f72097574d
Author: Christian Hogan <gi...@infliction.org>
Date: 2014-12-18T15:47:38Z
Table style tweaks.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-69635523
@benkeen Good catch! It looks like I had some weird rule in .gitignore to not commit the templates. Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-68540586
please take a look at our [Styleguide](https://github.com/apache/couchdb-fauxton/blob/master/styleguide.md) - we are using single quotes (`'`) and prefix CSS-selectors with `js-` when they interact with JavaScript. To access view-variables we are using `this.$()` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-69364536
Cool thank you!
It is not clear to me if we are using a cors-module with an own view or adding a config section to /_config as there is code for both - I think garren also mentioned that: https://github.com/apache/couchdb-fauxton/pull/208/files#r22057673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-69643196
Thanks @ocelotpotpie. Some functional problems:
- checking "Enable CORS" then clicking save doesn't save that setting.
- Adding a new item doesn't refresh the displayed list of CORS domains
- deleting a CORS domain shows the notification that it's been deleted, but the line remains in the page.
- updating an item in the page doesn't update the row - the "Update" button remains.
Also, two issues I mentioned in my last review are still around:
- the indentation for the sidebar isn't consistent with other pages.
- Going to the Main config page, then to the CORS page doesn't remove the "Add Option" link in the header. It should.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22414531
--- Diff: app/addons/cors/views.js ---
@@ -0,0 +1,100 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ "app",
+ "api",
+ "addons/cors/resources"
+],
+
+
+function (app, FauxtonAPI, CORS) {
+ var Views= {};
+
+ Views.CORSMain = FauxtonAPI.View.extend({
+ className: 'cors-page',
+ template: "addons/cors/templates/cors",
+ events: {
+ "submit form#corsForm": "submit"
+ },
+ establish: function(){
+ return [this.model.fetch()];
+ },
+ submit: function(e){
+ e.preventDefault();
+
+ if ($('#corsForm .enable_cors').is(':checked')) {
+ var enable_option = new CORS.ConfigModel({
+ section: "httpd",
+ attribute: "enable_cors",
+ value: "true"
+ });
+
+ var enable_creds = new CORS.ConfigModel({
+ section: "cors",
+ attribute: "credentials",
+ value: "true"
+ });
+
--- End diff --
We are using CamelCase instead of snake_case, `enable_option` and `enable_creds` are snake-cased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-69609183
Hi @ocelotpotpie, I'm getting a missing file: `origin_domain_table.html` on loading the CORS page. Mind taking a quick look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22057853
--- Diff: app/addons/cors/templates/cors.html ---
@@ -0,0 +1,31 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License"); you may not
+use this file except in compliance with the License. You may obtain a copy of
+the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+License for the specific language governing permissions and limitations under
+the License.
+-->
+
+<header id="cors-header">
+ <p><a href="">Cross-Origin Resource Sharing</a> (CORS) lets you connect to remote servers directly from the browser, so you can host browser-based apps on static pages and talk directly with CouchDB to load your data.</p>
+</header>
+
+<form id="corsForm">
+
+ <div class="cors-enable">
+ <label class="checkbox">
+ <input type="checkbox" class="enable_cors" name="enable_cors" <% if (typeof enable_cors !== 'undefined' && enable_cors =="true") { %> checked="checked" <% } %>> Enable CORS
--- End diff --
Could you move the logic of the if statement into the serialise function and then just have a resulting boolean here. So in serialze you would have:
var isCorsEnabled = false;
if (!_.isUndefined(enable_cors) && enable_cors =="true") {
isCorsEnabled = true;
}
return {
isCorsEnabled: isCorsEnabled
};
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22414462
--- Diff: app/addons/cors/templates/cors.html ---
@@ -0,0 +1,31 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License"); you may not
+use this file except in compliance with the License. You may obtain a copy of
+the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+License for the specific language governing permissions and limitations under
+the License.
+-->
+
+<header id="cors-header">
+ <p><a href="">Cross-Origin Resource Sharing</a> (CORS) lets you connect to remote servers directly from the browser, so you can host browser-based apps on static pages and talk directly with CouchDB to load your data.</p>
--- End diff --
this link is empty
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-68030730
Couple of small things:
- should the "Cross-Origin Resource Sharing" link link somewhere? Right now it just goes to #.
- the indentation of the 2 items on the Config page is a little too much. Compare with the Active Tasks sidebar, for example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-70101502
the testsuite is red @ocelotpotpie
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-69584425
@robertkowalski I cleaned up the redundant routes that garren mentioned previously.
The config section does automatically pull in all the config options for a user, so all of the CORS config options will show up in the main config area as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-68540095
It is not clear to me if we are using a cors-module with an own view or adding a config section to `/_config` as there is code for both - I think garren also mentioned that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-68553340
@robertkowalski Thanks for the feedback, Robert! I've pushed some changes to match the style guide as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22057621
--- Diff: app/addons/cors/resources.js ---
@@ -0,0 +1,58 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ "app",
+ "api"
+],
+
+function (app, FauxtonAPI) {
+ var CORS = FauxtonAPI.addon();
+
+
+ CORS.config = FauxtonAPI.Model.extend({
+ url: function() {
+ return app.host+"/_config/cors";
+ }
+ });
+
+ CORS.ConfigModel = Backbone.Model.extend({
+ documentation: "cors",
+
+ url: function () {
+ return app.host + '/_config/' + encodeURIComponent(this.get("section")) + '/' + encodeURIComponent(this.get("attribute"));
+ },
+
+ isNew: function () { return false; },
+
+ sync: function (method, model, options) {
+
+ var params = {
+ url: model.url(),
+ contentType: 'application/json',
+ dataType: 'json',
+ data: JSON.stringify(model.get('value'))
+ };
+
+ if (method === 'delete') {
+ params.type = 'DELETE';
+ } else {
+ params.type = 'PUT';
+ }
+
+ return $.ajax(params);
+ }
+
+ });
+
+ return CORS;
+});
--- End diff --
Another newline needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-72416166
@ocelotpotpie could you close this ticket. CORS is merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22057483
--- Diff: app/addons/cors/assets/less/cors.less ---
@@ -0,0 +1,68 @@
+/* Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+/* =cors
+ ---------------------------------------------------------------------- */
+@import "../../../../../assets/less/bootstrap/variables.less";
+@import "../../../../../assets/less/variables.less";
+@import "../../../../../assets/less/bootstrap/mixins.less";
+
+
+#cors-header {
+ margin: 18px 30px 0 30px;
+}
+
+#corsForm {
+ margin: 0;
+
+ .checkbox {
+ font-size: 16px;
+
+ input[type='checkbox'] {
+ margin-top: 4px;
+ }
+ }
+ .radio {
+ font-size: 16px;
+
+ input[type='radio'] {
+ margin-top: 4px;
+ }
+ }
+
+ .cors-enable {
+ padding: 10px 30px 18px 30px;
+ border-bottom: 1px solid #ccc;
+ }
+ #origin-domains-container {
+ display: none;
+ }
+ .origin-domains {
+ margin: 0;
+ padding: 18px 30px;
+ border-top: 1px solid #fff;
+ border-bottom: 1px solid #ccc;
+
+ p {
+ line-height: 36px;
+ }
+ .controls {
+ margin-top: 18px;
+ }
+ }
+ .form-actions {
+ padding: 18px 30px;
+ margin-top: 0;
+ border-top: 1px solid #fff;
+ }
+}
--- End diff --
On behalf of @robertkowalski could you add a new line here :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22414498
--- Diff: app/addons/cors/views.js ---
@@ -0,0 +1,100 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ "app",
+ "api",
+ "addons/cors/resources"
+],
+
+
+function (app, FauxtonAPI, CORS) {
+ var Views= {};
+
+ Views.CORSMain = FauxtonAPI.View.extend({
+ className: 'cors-page',
+ template: "addons/cors/templates/cors",
+ events: {
+ "submit form#corsForm": "submit"
+ },
+ establish: function(){
+ return [this.model.fetch()];
+ },
+ submit: function(e){
+ e.preventDefault();
+
+ if ($('#corsForm .enable_cors').is(':checked')) {
+ var enable_option = new CORS.ConfigModel({
+ section: "httpd",
+ attribute: "enable_cors",
+ value: "true"
+ });
+
+ var enable_creds = new CORS.ConfigModel({
+ section: "cors",
+ attribute: "credentials",
+ value: "true"
+ });
+
+ enable_option.save().then(function (response) {
+ var notification = FauxtonAPI.addNotification({
+ msg: "Your settings have been saved.",
+ type: "success",
+ clear: true
+ });
+ },
+ function (response, errorCode, errorMsg) {
+ var notification = FauxtonAPI.addNotification({
+ msg: "Sorry! There was an error. Code " + errorCode + ".",
+ type: "error",
+ clear: true
+ });
+ });
+
+ enable_creds.save();
+ } else {
+ var disable_option = new CORS.ConfigModel({
+ section: "httpd",
+ attribute: "enable_cors",
+ value: "false"
+ });
+
+ var disable_creds = new CORS.ConfigModel({
+ section: "cors",
+ attribute: "credentials",
+ value: "false"
+ });
+
+ disable_option.save().then(function (response) {
+ var notification = FauxtonAPI.addNotification({
+ msg: "Your settings have been saved.",
+ type: "success",
+ clear: true
+ });
+ },
+ function (response, errorCode, errorMsg) {
+ var notification = FauxtonAPI.addNotification({
+ msg: "Sorry! There was an error. Code " + errorCode + ".",
+ type: "error",
+ clear: true
+ });
+ });
+
+ disable_creds.save();
+ }
+ }
+ });
+
+ CORS.Views = Views;
+
+ return CORS;
+});
--- End diff --
newline missing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#discussion_r22057673
--- Diff: app/addons/cors/routes.js ---
@@ -0,0 +1,51 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'addons/cors/views'
+],
+
+function (app, FauxtonAPI, CORS) {
+
+ var CORSRouteObject = FauxtonAPI.RouteObject.extend({
--- End diff --
I don't think this needed if we have CORS in the config section?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Couchdb 2483 add cors to fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/208#issuecomment-67613761
@ocelotpotpie I picked up a couple bugs with this:
* There is no `serialise` function or `enable_cors` in the view so the checkbox for enable cors will always be unchecked
* If I refresh the page then the sidebar doesn't highlight the cors section
* In the sidebar just call it Cors instead of Cors config
* There is no list of origins that I've enabled Cors for.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---