You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by VinceOPS <gi...@git.apache.org> on 2016/12/01 23:06:06 UTC

[GitHub] cordova-browser pull request #25: CB-8260: (browser) Fix corrupted zip file ...

GitHub user VinceOPS opened a pull request:

    https://github.com/apache/cordova-browser/pull/25

    CB-8260: (browser) Fix corrupted zip file (build)

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Platform "browser" only.
    
    ### What does this PR do?
    Replace the node module `adm-zip`, which is known for corrupting some files when compressing a folder to a zip archive, by the module `archiver`.
    Update the build script in order to use `archiver` instead of `adm-zip`.
    
    ### What testing has been done on this change?
    Making sure that all the different types of file bundled in the newly built package.zip were properly compressed, and uncompressed.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/VinceOPS/cordova-browser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit 4ea3ad76414727e732e80ce69e100522e5dddc92
Author: Vince <vi...@gmail.com>
Date:   2016-12-01T22:50:23Z

    CB-8260: (browser) Fix corrupted zip file (build)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-browser pull request #25: CB-8260: (browser) Fix corrupted zip file ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-browser/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-browser issue #25: CB-8260: (browser) Fix corrupted zip file (build)

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-browser/pull/25
  
    I like this, and thank you, however, I am planning on removing zip functionality.
    I believe zipping was only added because someone decided that `build` needed some sort of output.
    Realistically, I think it makes more sense to let users zip their own build output as they see fit, and remove these extra deps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org