[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

[GitBox <gi...@apache.org>]

raducotescu commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679750345



##########
File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
##########
@@ -48,12 +47,24 @@
         TYPES
     }
 
-    /** The name of this partial */
-    @NotNull String getName();
+    /**
+     * Returns the partial info.
+     *
+     * @return the partial info
+     */
+    @NotNull PartialInfo getPartialInfo();
 
     /** Return a specific section of the partial, by name */
     @NotNull Optional<Section> getSection(SectionName name);
 
     /** Names of the Partials on which this one depends */
-    @NotNull Set<String> getRequiredPartialNames();
+    @NotNull Set<PartialInfo> getRequiredPartialNames();
+
+    /**
+     * Returns the SHA256 hash of the source that was used to build this partial.
+     *
+     * @return the SHA256 hash of the source that was used to build this partial
+     */
+    @NotNull String getSHA256Hash();

Review comment:
       I was initially thinking that two partials should be equal irrespective of where they are coming from and hence wanted to force the various
   implementations to use the same hash algorithm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org