[GitHub] [kafka] tombentley commented on a change in pull request #10193: MINOR: correct the error message of validating uint32

[GitBox <gi...@apache.org>]

tombentley commented on a change in pull request #10193:
URL: https://github.com/apache/kafka/pull/10193#discussion_r584646665



##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java
##########
@@ -320,7 +320,7 @@ public Long validate(Object item) {
             if (item instanceof Long)
                 return (Long) item;
             else
-                throw new SchemaException(item + " is not a Long.");
+                throw new SchemaException(item + " is not an unsigned integer.");

Review comment:
       This would be inconsistent with the other messages, which refer to Java types. It's a condition on the Java type, so including it in the message is reasonable imho.
   ```suggestion
                   throw new SchemaException(item + " is not a Long (encoding an unsigned integer).");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org