You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2013/12/27 02:18:58 UTC
[VOTE] Release [pool] 2.1 based on RC2
I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
Pool 2.1 RC2 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/pool/
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-022/
Details of changes since 2.0 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
The tag is here:
<http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
Site:
http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
(Broken links to Javadoc versions expected)
Clirr Report:
http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
RAT:
http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thanks!
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Mark Thomas <ma...@apache.org>.
On 27/12/2013 01:18, Phil Steitz wrote:
> [X] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
On 12/28/13, 2:38 AM, Benedikt Ritter wrote:
>
> Send from my mobile device
>
>> Am 28.12.2013 um 04:03 schrieb Phil Steitz <ph...@gmail.com>:
>>
>>> On 12/27/13, 10:21 AM, Oliver Heger wrote:
>>> Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and
>>> site look good.
>>>
>>> So +1
>>>
>>> Minor nit: The ant build did not work for me, obviously due to missing
>>> cglib dependencies. I guess I have to define some properties, but this
>>> is not described nor is there a sample properties file.
>> Ugh. Thanks for pointing this out. There is a
>> build.properties.sample in trunk, but the src assembly does not pick
>> it up. Not a blocker, IMO, but fixed now in trunk.
> This is intentional. The file serves as a sample. One has to fill in the parameters for the environment and than rename/copy the file to build.properties. That file should be picked up by the build.
I know. I created the file ;) But I forgot to update the maven
assembly descriptor to pick it up when creating the source distro.
Fixed now in trunk, but I don't think this is a blocker.
Phil
>
> Benedikt
>
>> Phil
>>> Oliver
>>>
>>> Am 27.12.2013 02:18, schrieb Phil Steitz:
>>>> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>>>>
>>>> Pool 2.1 RC2 is available for review here:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>>>
>>>> Maven artifacts are here:
>>>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>>>
>>>> Details of changes since 2.0 are in the release notes:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>>
>>>> The tag is here:
>>>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>>>
>>>> Site:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>>>> (Broken links to Javadoc versions expected)
>>>>
>>>> Clirr Report:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>>>
>>>> RAT:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>>>
>>>> Please review the release candidate and vote.
>>>> This vote will close no sooner that 72 hours from now
>>>>
>>>> [ ] +1 Release these artifacts
>>>> [ ] +0 OK, but...
>>>> [ ] -0 OK, but really should fix...
>>>> [ ] -1 I oppose this release because...
>>>>
>>>> Thanks!
>>>>
>>>> Phil
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>> .
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
> .
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Benedikt Ritter <be...@gmail.com>.
Send from my mobile device
> Am 28.12.2013 um 04:03 schrieb Phil Steitz <ph...@gmail.com>:
>
>> On 12/27/13, 10:21 AM, Oliver Heger wrote:
>> Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and
>> site look good.
>>
>> So +1
>>
>> Minor nit: The ant build did not work for me, obviously due to missing
>> cglib dependencies. I guess I have to define some properties, but this
>> is not described nor is there a sample properties file.
>
> Ugh. Thanks for pointing this out. There is a
> build.properties.sample in trunk, but the src assembly does not pick
> it up. Not a blocker, IMO, but fixed now in trunk.
This is intentional. The file serves as a sample. One has to fill in the parameters for the environment and than rename/copy the file to build.properties. That file should be picked up by the build.
Benedikt
>
> Phil
>>
>> Oliver
>>
>> Am 27.12.2013 02:18, schrieb Phil Steitz:
>>> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>>>
>>> Pool 2.1 RC2 is available for review here:
>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>>
>>> Maven artifacts are here:
>>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>>
>>> Details of changes since 2.0 are in the release notes:
>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>
>>> The tag is here:
>>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>>
>>> Site:
>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>>> (Broken links to Javadoc versions expected)
>>>
>>> Clirr Report:
>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>>
>>> RAT:
>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>>
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thanks!
>>>
>>> Phil
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>> .
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
On 12/27/13, 10:21 AM, Oliver Heger wrote:
> Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and
> site look good.
>
> So +1
>
> Minor nit: The ant build did not work for me, obviously due to missing
> cglib dependencies. I guess I have to define some properties, but this
> is not described nor is there a sample properties file.
Ugh. Thanks for pointing this out. There is a
build.properties.sample in trunk, but the src assembly does not pick
it up. Not a blocker, IMO, but fixed now in trunk.
Phil
>
> Oliver
>
> Am 27.12.2013 02:18, schrieb Phil Steitz:
>> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>>
>> Pool 2.1 RC2 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>
>> Maven artifacts are here:
>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>
>> Details of changes since 2.0 are in the release notes:
>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> The tag is here:
>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>
>> Site:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>> (Broken links to Javadoc versions expected)
>>
>> Clirr Report:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>
>> RAT:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
> .
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Oliver Heger <ol...@oliver-heger.de>.
Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and
site look good.
So +1
Minor nit: The ant build did not work for me, obviously due to missing
cglib dependencies. I guess I have to define some properties, but this
is not described nor is there a sample properties file.
Oliver
Am 27.12.2013 02:18, schrieb Phil Steitz:
> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Jörg Schaible <jo...@gmx.de>.
+1, build from source succeeds for all my JDKs (incl. Java 8)
Phil Steitz wrote:
> I have updated the release notes and MBean interface class javadoc to
> address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
>
<http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
Here is my +1
Phil
On 12/26/13, 5:18 PM, Phil Steitz wrote:
> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RESULT: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
This vote has passed, with +1 votes from
Oliver Heger
Phil Steitz
Luc Maisonobe
Mark Thomas
Jörg Schaible
and no other votes.
Thanks to all who reviewed the RC.
Phil
On 12/26/13, 5:18 PM, Phil Steitz wrote:
> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
Lost in my discussion on BC is my gratitude for Phil's return to Commons
and my thanks for preparing an RC for a crucial component.
Thank you Phil!
Gary
On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz <ph...@gmail.com> wrote:
> I have updated the release notes and MBean interface class javadoc to
> address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> >http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Dec 28, 2013 at 1:30 PM, Phil Steitz <ph...@gmail.com> wrote:
> On 12/28/13, 8:07 AM, Gary Gregory wrote:
> > On Fri, Dec 27, 2013 at 10:15 PM, Phil Steitz <ph...@gmail.com>
> wrote:
> >
> >> On 12/27/13, 2:09 PM, Gary Gregory wrote:
> >>> I have to say that the 'fix' for the Clirr issue is underwhelming, it
> >> does
> >>> not exist IMO.
> >>>
> >>> - The new API does not have a @since 2.1 in the Javadoc.
> >> Should be fixed, but not a blocker, IMO.
> >>> - There is nothing on the site that addresses the Clirr error and why
> it
> >> is
> >>> OK to have.
> >>> - The release notes do not talk about the Clirr error as well.
> >> People reading the site and/or release notes have limited time, like
> >> the rest of us. Anyone actually looking at the Clirr report will
> >> get immediately that a method was added to an Mbean interface - no
> >> consequence to them.
> >
> > That might be true for simple projects that only have one layer of
> > dependencies that I control. In larger projects though, when more than
> one
> > jar depends on [pool], that will not be the case.
>
> Can you provide a real example where the "breakage" in question
> could make a difference to any application at any layer of anyone's
> stack?
>
I am not going to take the time right to put on my software archeologist
hat and find a specific example in our programs but we do have a larger
application server that depends on the large Apache code bases of Active MQ
and CXF (and their dependencies) in addition to Eclipse Jetty and a pile of
Commons components. Because all of these code bases do NOT by policy, or
even if by policy, reliably, change package names when they break BC, it
can be a hackathon when we need to update dependencies. No BC breakage is
one less hurdle to move the stack along. Yes, of course, we then have to
deal with semantic changes, but avoiding both compile-time and runtime
surprise is always a good thing. So whenever I see I BC break without a
package change, I have to wonder what trouble lies ahead. If there is a
package name change, then I have to take conscious action to use the new
version by changing imports in my app, which also does not break 3rd party
code.
Gary
> Phil
>
> > This is when I want to
> > know that [pool] is BC or not, if it is not (like 2.1) I run the risk of
> > blowing up the app because I am not the only one using [pool].
> > If I see a
> > red Clirr that is NOT documented, it looks either like an omission
> > (relatively safe but undocumented) or a bug (the change should not have
> > been made). If the red Clirr report is not documented, I, as a user am
> left
> > in the dark. Why would we want to leave users in the dark? It does not
> > matter that the change is too a Foo or a Bar kind of interface because I
> am
> > not the only one using pool. If it is documented, then it's a better for
> > all. I'd be OK with this if the site is updated after the release, even
> > though it's a mess to have -SNAPSHOT sites (a different topic).
> >
> > Gary
> >
> >
> >
> >
> >> Why distract readers of release notes who are
> >> scanning for things relevant to them with what amounts to a
> >> non-issue? Similar for web site doco. Needless distraction, IMO,
> >> unless someone wants to step up to author a full section on JMX
> >> instrumentation, which would be valuable / substantive and could
> >> include disclaimers on interfaces. Again, this is not a release
> >> blocker, IMO. I would rather proceed with the release and welcome
> >> contributions to the web site from any / all who want to help with it.
> >>
> >> Phil
> >>> I can't bring myself to -1 this since the software is not broken, but
> the
> >>> documentation feels broken to me.
> >>>
> >>> Gary
> >>>
> >>>
> >>> On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz <ph...@gmail.com>
> >> wrote:
> >>>> I have updated the release notes and MBean interface class javadoc to
> >>>> address feedback from RC1.
> >>>>
> >>>> Pool 2.1 RC2 is available for review here:
> >>>> https://dist.apache.org/repos/dist/dev/commons/pool/
> >>>>
> >>>> Maven artifacts are here:
> >>>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-022/
> >>>> Details of changes since 2.0 are in the release notes:
> >>>>
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
> >>>>
> >>>> The tag is here:
> >>>> <
> >> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> >>>>>
> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> >>>> Site:
> >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> >>>> (Broken links to Javadoc versions expected)
> >>>>
> >>>> Clirr Report:
> >>>>
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
> >>>>
> >>>> RAT:
> >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
> >>>>
> >>>> Please review the release candidate and vote.
> >>>> This vote will close no sooner that 72 hours from now
> >>>>
> >>>> [ ] +1 Release these artifacts
> >>>> [ ] +0 OK, but...
> >>>> [ ] -0 OK, but really should fix...
> >>>> [ ] -1 I oppose this release because...
> >>>>
> >>>> Thanks!
> >>>>
> >>>> Phil
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>>
> >>>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
On 12/28/13, 8:07 AM, Gary Gregory wrote:
> On Fri, Dec 27, 2013 at 10:15 PM, Phil Steitz <ph...@gmail.com> wrote:
>
>> On 12/27/13, 2:09 PM, Gary Gregory wrote:
>>> I have to say that the 'fix' for the Clirr issue is underwhelming, it
>> does
>>> not exist IMO.
>>>
>>> - The new API does not have a @since 2.1 in the Javadoc.
>> Should be fixed, but not a blocker, IMO.
>>> - There is nothing on the site that addresses the Clirr error and why it
>> is
>>> OK to have.
>>> - The release notes do not talk about the Clirr error as well.
>> People reading the site and/or release notes have limited time, like
>> the rest of us. Anyone actually looking at the Clirr report will
>> get immediately that a method was added to an Mbean interface - no
>> consequence to them.
>
> That might be true for simple projects that only have one layer of
> dependencies that I control. In larger projects though, when more than one
> jar depends on [pool], that will not be the case.
Can you provide a real example where the "breakage" in question
could make a difference to any application at any layer of anyone's
stack?
Phil
> This is when I want to
> know that [pool] is BC or not, if it is not (like 2.1) I run the risk of
> blowing up the app because I am not the only one using [pool].
> If I see a
> red Clirr that is NOT documented, it looks either like an omission
> (relatively safe but undocumented) or a bug (the change should not have
> been made). If the red Clirr report is not documented, I, as a user am left
> in the dark. Why would we want to leave users in the dark? It does not
> matter that the change is too a Foo or a Bar kind of interface because I am
> not the only one using pool. If it is documented, then it's a better for
> all. I'd be OK with this if the site is updated after the release, even
> though it's a mess to have -SNAPSHOT sites (a different topic).
>
> Gary
>
>
>
>
>> Why distract readers of release notes who are
>> scanning for things relevant to them with what amounts to a
>> non-issue? Similar for web site doco. Needless distraction, IMO,
>> unless someone wants to step up to author a full section on JMX
>> instrumentation, which would be valuable / substantive and could
>> include disclaimers on interfaces. Again, this is not a release
>> blocker, IMO. I would rather proceed with the release and welcome
>> contributions to the web site from any / all who want to help with it.
>>
>> Phil
>>> I can't bring myself to -1 this since the software is not broken, but the
>>> documentation feels broken to me.
>>>
>>> Gary
>>>
>>>
>>> On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz <ph...@gmail.com>
>> wrote:
>>>> I have updated the release notes and MBean interface class javadoc to
>>>> address feedback from RC1.
>>>>
>>>> Pool 2.1 RC2 is available for review here:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>>>
>>>> Maven artifacts are here:
>>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>>> Details of changes since 2.0 are in the release notes:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>>
>>>> The tag is here:
>>>> <
>> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>>>> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>>> Site:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>>>> (Broken links to Javadoc versions expected)
>>>>
>>>> Clirr Report:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>>>
>>>> RAT:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>>>
>>>> Please review the release candidate and vote.
>>>> This vote will close no sooner that 72 hours from now
>>>>
>>>> [ ] +1 Release these artifacts
>>>> [ ] +0 OK, but...
>>>> [ ] -0 OK, but really should fix...
>>>> [ ] -1 I oppose this release because...
>>>>
>>>> Thanks!
>>>>
>>>> Phil
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Dec 27, 2013 at 10:15 PM, Phil Steitz <ph...@gmail.com> wrote:
> On 12/27/13, 2:09 PM, Gary Gregory wrote:
> > I have to say that the 'fix' for the Clirr issue is underwhelming, it
> does
> > not exist IMO.
> >
> > - The new API does not have a @since 2.1 in the Javadoc.
>
> Should be fixed, but not a blocker, IMO.
> > - There is nothing on the site that addresses the Clirr error and why it
> is
> > OK to have.
> > - The release notes do not talk about the Clirr error as well.
>
> People reading the site and/or release notes have limited time, like
> the rest of us. Anyone actually looking at the Clirr report will
> get immediately that a method was added to an Mbean interface - no
> consequence to them.
That might be true for simple projects that only have one layer of
dependencies that I control. In larger projects though, when more than one
jar depends on [pool], that will not be the case. This is when I want to
know that [pool] is BC or not, if it is not (like 2.1) I run the risk of
blowing up the app because I am not the only one using [pool]. If I see a
red Clirr that is NOT documented, it looks either like an omission
(relatively safe but undocumented) or a bug (the change should not have
been made). If the red Clirr report is not documented, I, as a user am left
in the dark. Why would we want to leave users in the dark? It does not
matter that the change is too a Foo or a Bar kind of interface because I am
not the only one using pool. If it is documented, then it's a better for
all. I'd be OK with this if the site is updated after the release, even
though it's a mess to have -SNAPSHOT sites (a different topic).
Gary
> Why distract readers of release notes who are
> scanning for things relevant to them with what amounts to a
> non-issue? Similar for web site doco. Needless distraction, IMO,
> unless someone wants to step up to author a full section on JMX
> instrumentation, which would be valuable / substantive and could
> include disclaimers on interfaces. Again, this is not a release
> blocker, IMO. I would rather proceed with the release and welcome
> contributions to the web site from any / all who want to help with it.
>
> Phil
> >
> > I can't bring myself to -1 this since the software is not broken, but the
> > documentation feels broken to me.
> >
> > Gary
> >
> >
> > On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz <ph...@gmail.com>
> wrote:
> >
> >> I have updated the release notes and MBean interface class javadoc to
> >> address feedback from RC1.
> >>
> >> Pool 2.1 RC2 is available for review here:
> >> https://dist.apache.org/repos/dist/dev/commons/pool/
> >>
> >> Maven artifacts are here:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-022/
> >>
> >> Details of changes since 2.0 are in the release notes:
> >> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
> >>
> >> The tag is here:
> >> <
> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> >>> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> >> Site:
> >> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> >> (Broken links to Javadoc versions expected)
> >>
> >> Clirr Report:
> >> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
> >>
> >> RAT:
> >> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
> >>
> >> Please review the release candidate and vote.
> >> This vote will close no sooner that 72 hours from now
> >>
> >> [ ] +1 Release these artifacts
> >> [ ] +0 OK, but...
> >> [ ] -0 OK, but really should fix...
> >> [ ] -1 I oppose this release because...
> >>
> >> Thanks!
> >>
> >> Phil
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
On 12/27/13, 2:09 PM, Gary Gregory wrote:
> I have to say that the 'fix' for the Clirr issue is underwhelming, it does
> not exist IMO.
>
> - The new API does not have a @since 2.1 in the Javadoc.
Should be fixed, but not a blocker, IMO.
> - There is nothing on the site that addresses the Clirr error and why it is
> OK to have.
> - The release notes do not talk about the Clirr error as well.
People reading the site and/or release notes have limited time, like
the rest of us. Anyone actually looking at the Clirr report will
get immediately that a method was added to an Mbean interface - no
consequence to them. Why distract readers of release notes who are
scanning for things relevant to them with what amounts to a
non-issue? Similar for web site doco. Needless distraction, IMO,
unless someone wants to step up to author a full section on JMX
instrumentation, which would be valuable / substantive and could
include disclaimers on interfaces. Again, this is not a release
blocker, IMO. I would rather proceed with the release and welcome
contributions to the web site from any / all who want to help with it.
Phil
>
> I can't bring myself to -1 this since the software is not broken, but the
> documentation feels broken to me.
>
> Gary
>
>
> On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz <ph...@gmail.com> wrote:
>
>> I have updated the release notes and MBean interface class javadoc to
>> address feedback from RC1.
>>
>> Pool 2.1 RC2 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>
>> Maven artifacts are here:
>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>
>> Details of changes since 2.0 are in the release notes:
>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> The tag is here:
>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>> Site:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>> (Broken links to Javadoc versions expected)
>>
>> Clirr Report:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>
>> RAT:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
I have to say that the 'fix' for the Clirr issue is underwhelming, it does
not exist IMO.
- The new API does not have a @since 2.1 in the Javadoc.
- There is nothing on the site that addresses the Clirr error and why it is
OK to have.
- The release notes do not talk about the Clirr error as well.
I can't bring myself to -1 this since the software is not broken, but the
documentation feels broken to me.
Gary
On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz <ph...@gmail.com> wrote:
> I have updated the release notes and MBean interface class javadoc to
> address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> >http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
On 12/28/13, 10:39 AM, Luc Maisonobe wrote:
> Le 28/12/2013 18:51, Phil Steitz a écrit :
>> On 12/28/13, 2:23 AM, Luc Maisonobe wrote:
>>> Le 27/12/2013 02:18, Phil Steitz a écrit :
>>>> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>>>>
>>>> Pool 2.1 RC2 is available for review here:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>>>
>>>> Maven artifacts are here:
>>>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>>>
>>>> Details of changes since 2.0 are in the release notes:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>>
>>>> The tag is here:
>>>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>>> The tag does include a doc top level directory with three java files:
>>> ReaderUtilClient.java ReaderUtil.java StringBufferFactory.java
>>>
>>> These three files are not in the source distribution files in
>>> <https://dist.apache.org/repos/dist/dev/commons/pool/source/>.
>>>
>>> Is this expected?
>> I think it is OK, the files are just there to provide access to /
>> validation of source in the examples in the web site - i.e., there
>> is no real value in adding them to the source distro. But if you or
>> others think it is essential that the tag matches the source distro
>> exactly, this plus the build.properties.sample issue identified by
>> Olivier could justify another RC. I am ambivalent at this point.
> I don't have a clear cut opinion on this. If these sources are not
> really needed, then they can be left out for this version. It would be
> worth adding them to the list of archived source in the pom for next
> release.
I want to keep them in svn because they match the examples on the
site. They should just probably be excluded when making the tag.
Phil
>
> Anyway, here is my +1.
>
> Luc
>
>> Phil
>>> Luc
>>>
>>>> Site:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>>>> (Broken links to Javadoc versions expected)
>>>>
>>>> Clirr Report:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>>>
>>>> RAT:
>>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>>>
>>>> Please review the release candidate and vote.
>>>> This vote will close no sooner that 72 hours from now
>>>>
>>>> [ ] +1 Release these artifacts
>>>> [ ] +0 OK, but...
>>>> [ ] -0 OK, but really should fix...
>>>> [ ] -1 I oppose this release because...
>>>>
>>>> Thanks!
>>>>
>>>> Phil
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>> .
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Luc Maisonobe <lu...@spaceroots.org>.
Le 28/12/2013 18:51, Phil Steitz a écrit :
> On 12/28/13, 2:23 AM, Luc Maisonobe wrote:
>> Le 27/12/2013 02:18, Phil Steitz a écrit :
>>> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>>>
>>> Pool 2.1 RC2 is available for review here:
>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>>
>>> Maven artifacts are here:
>>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>>
>>> Details of changes since 2.0 are in the release notes:
>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>
>>> The tag is here:
>>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
>> The tag does include a doc top level directory with three java files:
>> ReaderUtilClient.java ReaderUtil.java StringBufferFactory.java
>>
>> These three files are not in the source distribution files in
>> <https://dist.apache.org/repos/dist/dev/commons/pool/source/>.
>>
>> Is this expected?
>
> I think it is OK, the files are just there to provide access to /
> validation of source in the examples in the web site - i.e., there
> is no real value in adding them to the source distro. But if you or
> others think it is essential that the tag matches the source distro
> exactly, this plus the build.properties.sample issue identified by
> Olivier could justify another RC. I am ambivalent at this point.
I don't have a clear cut opinion on this. If these sources are not
really needed, then they can be left out for this version. It would be
worth adding them to the list of archived source in the pom for next
release.
Anyway, here is my +1.
Luc
>
> Phil
>>
>> Luc
>>
>>> Site:
>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>>> (Broken links to Javadoc versions expected)
>>>
>>> Clirr Report:
>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>>
>>> RAT:
>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>>
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thanks!
>>>
>>> Phil
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>> .
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Phil Steitz <ph...@gmail.com>.
On 12/28/13, 2:23 AM, Luc Maisonobe wrote:
> Le 27/12/2013 02:18, Phil Steitz a écrit :
>> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>>
>> Pool 2.1 RC2 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>
>> Maven artifacts are here:
>> https://repository.apache.org/content/repositories/orgapachecommons-022/
>>
>> Details of changes since 2.0 are in the release notes:
>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> The tag is here:
>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
> The tag does include a doc top level directory with three java files:
> ReaderUtilClient.java ReaderUtil.java StringBufferFactory.java
>
> These three files are not in the source distribution files in
> <https://dist.apache.org/repos/dist/dev/commons/pool/source/>.
>
> Is this expected?
I think it is OK, the files are just there to provide access to /
validation of source in the examples in the web site - i.e., there
is no real value in adding them to the source distro. But if you or
others think it is essential that the tag matches the source distro
exactly, this plus the build.properties.sample issue identified by
Olivier could justify another RC. I am ambivalent at this point.
Phil
>
> Luc
>
>> Site:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
>> (Broken links to Javadoc versions expected)
>>
>> Clirr Report:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>>
>> RAT:
>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
> .
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release [pool] 2.1 based on RC2
Posted by Luc Maisonobe <lu...@spaceroots.org>.
Le 27/12/2013 02:18, Phil Steitz a écrit :
> I have updated the release notes and MBean interface class javadoc to address feedback from RC1.
>
> Pool 2.1 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-022/
>
> Details of changes since 2.0 are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> The tag is here:
> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/
The tag does include a doc top level directory with three java files:
ReaderUtilClient.java ReaderUtil.java StringBufferFactory.java
These three files are not in the source distribution files in
<https://dist.apache.org/repos/dist/dev/commons/pool/source/>.
Is this expected?
Luc
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/
> (Broken links to Javadoc versions expected)
>
> Clirr Report:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html
>
> RAT:
> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org