[GitHub] [incubator-doris] qidaye commented on a diff in pull request #9559: [feature-wip](hudi) Step1: Support create hudi external table

[GitBox <gi...@apache.org>]

qidaye commented on code in PR #9559:
URL: https://github.com/apache/incubator-doris/pull/9559#discussion_r874419025


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -4105,6 +4111,44 @@ private void createHiveTable(Database db, CreateTableStmt stmt) throws DdlExcept
         LOG.info("successfully create table[{}-{}]", tableName, tableId);
     }
 
+    private void createHudiTable(Database db, CreateTableStmt stmt) throws DdlException {
+        String tableName = stmt.getTableName();
+        List<Column> columns = stmt.getColumns();
+        long tableId = getNextId();
+        HudiTable hudiTable = new HudiTable(tableId, tableName, columns, stmt.getProperties());

Review Comment:
   Where to get the table schema if no columns are specified when creating the table？



##########
fe/fe-core/src/test/java/org/apache/doris/analysis/CreateTableStmtTest.java:
##########
@@ -274,4 +274,21 @@ public void testCreateIcebergTable() throws UserException {
                 "\"iceberg.hive.metastore.uris\"  =  \"thrift://127.0.0.1:9087\",\n" +
                 "\"iceberg.table\"  =  \"test\")", stmt.toString());
     }
+
+    @Test
+    public void testCreateHudiTable() throws UserException {

Review Comment:
   It's better to add another test case with column definations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org