You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "kkewwei (via GitHub)" <gi...@apache.org> on 2026/05/20 10:04:43 UTC
[PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
kkewwei opened a new pull request, #16089:
URL: https://github.com/apache/lucene/pull/16089
### Description
If We know the cost and is large enough, switch the builder to FixedBitSet eagerly, instead of being accumulated in temporary int[] buffers and copied later by `upgradeToBitSet`.
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "kkewwei (via GitHub)" <gi...@apache.org>.
kkewwei commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5118817824
@epotyom Very thank you for your review, sorry for my delayed reply.
You're right, my previous “at most two crossing leaves” argument only applies to one-dimensional range queries. In multiple dimensions, many leaves may cross the query boundary and `estimateDocCount()` may trigger an eager FixedBitSet allocation even when the actual result is sparse.
I haven't found a robust way to solve it, how about restrict to one-dimensional `PointRangeQuery` and remove it from `SpatialQuery` and `PointInSetQuery`.?
```
// PointRangeQuery
if (cost != -1 && numDims == 1) {
result.expectMore(cost);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-4618074963
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "kkewwei (via GitHub)" <gi...@apache.org>.
kkewwei commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-4687498759
Each query yields at most two CELL_CROSSES_QUERY leaf node, while each enforces a default document limit of 512. This yields an upper bound estimate of (512/2) × 2 documents. Additionally, the estimation logic has been optimized to boost the precision of CELL_CROSSES_QUERY calculations https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/PointValues.java#L468.
For range query—which typically match substantial volumes of data—the `cost` estimation delivers high accuracy in most real-world cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5239002045
The code LGTM, thanks @kkewwei! It would still be great if you could run the luceneutil benchmarks to report wins. The README ( https://github.com/mikemccand/luceneutil/blob/main/README.md ) has all the details on how to set them up and run them, but feel free to ask me if anything's unclear.
If I'm not mistaken, the "IntNRQ" task category creates a 1-dimensional PointRangeQuery, but I'm not sure the ranges these tasks use (see this task file for example: https://github.com/mikemccand/luceneutil/blob/ae1d259a4cc97a4864294932607c610c2355b16f/tasks/wikimedium.10M.tasks#L1585) are wide enough to trigger the eager bit-set upgrade path. You may need to add a new task category with a wider range, either locally or by contributing it to luceneutil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5301017583
> @epotyom Can you help merge in your spare time?
I don't have permissions to merge, we need a committer to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "kkewwei (via GitHub)" <gi...@apache.org>.
kkewwei commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5249586025
@epotyom Thanks for the detailed explanation.
I added a `SubHalfIntNRQ` benchmark task set in `luceneutil`(I'd be happy to submit a PR if necessary.)
https://github.com/kkewwei/luceneutil/commit/2c44e536d3a42b686ed4c77e3c10be0976291bfd
The benchmark command was:
```
python3 util/src/python/localrun.py wikimediumall
```
After 19 benchmark rounds, the final results are:
```
TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value
HighTermTitleBDVSort 3.72 (10.6%) 3.62 (11.0%) -2.9% ( -22% - 21%) 0.402
BrowseDateSSDVFacets 0.69 (11.5%) 0.68 (12.3%) -1.5% ( -22% - 25%) 0.692
OrHighNotHigh 110.14 (4.2%) 108.66 (6.5%) -1.3% ( -11% - 9%) 0.434
OrNotHighHigh 93.69 (4.9%) 92.89 (7.8%) -0.9% ( -12% - 12%) 0.679
AndHighHigh 29.45 (4.5%) 29.22 (5.4%) -0.8% ( -10% - 9%) 0.614
HighTermTitleSort 60.95 (4.1%) 60.55 (6.1%) -0.7% ( -10% - 9%) 0.692
OrHighNotMed 172.16 (5.2%) 171.17 (5.9%) -0.6% ( -11% - 11%) 0.743
AndHighMed 106.80 (3.3%) 106.30 (5.1%) -0.5% ( -8% - 8%) 0.729
IntSet 224.19 (6.4%) 223.60 (6.2%) -0.3% ( -12% - 13%) 0.895
BM25MSM2 2.90 (5.0%) 2.90 (3.4%) -0.1% ( -8% - 8%) 0.935
HighSloppyPhrase 2.08 (6.8%) 2.08 (4.8%) -0.0% ( -10% - 12%) 0.992
MedSloppyPhrase 5.46 (4.4%) 5.46 (8.0%) 0.0% ( -11% - 12%) 0.991
AndHighMedDayTaxoFacets 6.38 (4.4%) 6.38 (5.6%) 0.0% ( -9% - 10%) 0.984
Fuzzy2 38.27 (3.4%) 38.29 (4.2%) 0.1% ( -7% - 7%) 0.962
HighSpanNear 2.56 (5.0%) 2.57 (3.6%) 0.2% ( -7% - 9%) 0.912
OrHighNotLow 299.15 (5.9%) 299.71 (6.9%) 0.2% ( -11% - 13%) 0.927
Fuzzy1 47.54 (5.0%) 47.74 (5.1%) 0.4% ( -9% - 11%) 0.790
MedSpanNear 2.75 (4.3%) 2.76 (4.0%) 0.5% ( -7% - 9%) 0.680
HighTerm 314.23 (3.3%) 316.03 (2.6%) 0.6% ( -5% - 6%) 0.543
IntNRQ 26.50 (4.6%) 26.65 (5.6%) 0.6% ( -9% - 11%) 0.721
LowIntervalsOrdered 40.82 (8.9%) 41.06 (8.9%) 0.6% ( -15% - 20%) 0.835
MedTerm 470.30 (4.6%) 473.25 (3.9%) 0.6% ( -7% - 9%) 0.642
AndMissingHigh 1353.29 (6.8%) 1361.82 (6.6%) 0.6% ( -11% - 15%) 0.766
OrNotHighLow 276.98 (7.1%) 278.93 (7.2%) 0.7% ( -12% - 16%) 0.755
AndHighLow 478.43 (6.8%) 482.88 (7.4%) 0.9% ( -12% - 16%) 0.680
BrowseRandomLabelSSDVFacets 1.83 (7.9%) 1.85 (5.8%) 0.9% ( -11% - 15%) 0.669
LowPhrase 17.35 (3.8%) 17.52 (5.6%) 0.9% ( -8% - 10%) 0.529
OrHighLow 274.67 (2.9%) 277.54 (5.5%) 1.0% ( -7% - 9%) 0.451
PKLookup 172.63 (8.8%) 174.54 (7.8%) 1.1% ( -14% - 19%) 0.673
OrHighMed 100.26 (5.3%) 101.39 (3.9%) 1.1% ( -7% - 10%) 0.441
LowSpanNear 15.76 (3.4%) 15.95 (3.8%) 1.2% ( -5% - 8%) 0.304
OrHighHigh 34.17 (6.6%) 34.59 (4.7%) 1.2% ( -9% - 13%) 0.496
OrNotHighMed 135.60 (5.1%) 137.28 (8.3%) 1.2% ( -11% - 15%) 0.568
HighIntervalsOrdered 7.98 (6.5%) 8.08 (6.0%) 1.3% ( -10% - 14%) 0.511
Wildcard 36.12 (5.2%) 36.62 (4.2%) 1.4% ( -7% - 11%) 0.358
TermDTSort 62.91 (12.0%) 63.77 (11.9%) 1.4% ( -20% - 28%) 0.716
Respell 30.21 (5.2%) 30.63 (4.0%) 1.4% ( -7% - 11%) 0.347
MedTermDayTaxoFacets 7.00 (5.8%) 7.10 (4.5%) 1.5% ( -8% - 12%) 0.368
HighTermMonthSort 1105.13 (6.5%) 1122.67 (8.9%) 1.6% ( -12% - 18%) 0.518
LowSloppyPhrase 31.88 (4.1%) 32.42 (5.0%) 1.7% ( -7% - 11%) 0.239
MedPhrase 89.99 (4.1%) 91.60 (4.9%) 1.8% ( -6% - 11%) 0.213
MedIntervalsOrdered 16.22 (9.1%) 16.51 (5.3%) 1.8% ( -11% - 17%) 0.444
ConstMSM2 9.94 (6.7%) 10.16 (3.6%) 2.2% ( -7% - 13%) 0.204
HighPhrase 31.51 (5.7%) 32.20 (5.2%) 2.2% ( -8% - 13%) 0.206
HighTermDayOfYearSort 150.79 (6.7%) 154.30 (7.3%) 2.3% ( -10% - 17%) 0.291
LowTerm 821.14 (5.6%) 840.80 (6.5%) 2.4% ( -9% - 15%) 0.214
Prefix3 75.96 (7.2%) 78.10 (6.6%) 2.8% ( -10% - 17%) 0.197
BrowseDayOfYearTaxoFacets 3.87 (32.9%) 3.98 (38.4%) 2.8% ( -51% - 110%) 0.802
AndHighHighDayTaxoFacets 4.78 (5.5%) 4.93 (4.5%) 3.2% ( -6% - 13%) 0.045
OrHighMedDayTaxoFacets 0.75 (6.4%) 0.78 (5.8%) 3.7% ( -8% - 16%) 0.058
BrowseMonthSSDVFacets 3.43 (12.3%) 3.57 (21.8%) 3.9% ( -26% - 43%) 0.481
range 2326.07 (7.8%) 2429.10 (11.6%) 4.4% ( -13% - 25%) 0.156
BrowseDayOfYearSSDVFacets 3.20 (14.9%) 3.38 (20.2%) 5.5% ( -25% - 47%) 0.331
BrowseRandomLabelTaxoFacets 2.32 (19.0%) 2.45 (32.8%) 5.6% ( -38% - 70%) 0.509
SubHalfIntNRQ 92.60 (3.8%) 99.04 (7.8%) 7.0% ( -4% - 19%) 0.000
BrowseDateTaxoFacets 3.66 (30.3%) 3.92 (41.0%) 7.2% ( -49% - 112%) 0.530
BrowseMonthTaxoFacets 4.14 (46.8%) 5.04 (63.0%) 21.6% ( -60% - 247%) 0.218
```
So this change shows about a 7% QPS improvement for the new `SubHalfIntNRQ` workload, which is intended to exercise 1D `IntPoint` range queries that are wide enough to trigger `DocIdSetBuilder.expectMore(cost)`, while still staying below the inverse-query threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "gf2121 (via GitHub)" <gi...@apache.org>.
gf2121 commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5890132112
Thank you, and sorry for the late reply!
I initially assumed that 1D range queries on BKD trees would always match a contiguous run of leaf blocks, and that a single `visitor#grow` call would suffice. After reconsidering, I realized there are cases where grow is called multiple times — specifically, in the worst case it is called `2 * log N` times (where N is the number of leaf blocks), as illustrated in the diagram below.
<img width="3819" height="1323" alt="image" src="https://github.com/user-attachments/assets/13b99448-7baa-4bcc-ab3c-0f301dc7e57e" />
The change looks good to me. I'll merge it tomorrow unless someone beats me to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-4861259860
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on code in PR #16089:
URL: https://github.com/apache/lucene/pull/16089#discussion_r3379834594
##########
lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java:
##########
@@ -231,6 +231,20 @@ public BulkAdder grow(int numDocs) {
return adder;
}
+ /**
+ * If the builder is still in buffer (sparse) mode and this hint indicates the total number of
+ * docs will exceed the threshold above which a FixedBitSet is preferred, eagerly upgrade to
+ * FixedBitSet.
+ */
+ public void growHint(long expectedDocs) {
Review Comment:
[nit] Maybe rename to avoid the impression that the method resizes (`grows`) some buffers - e.g. `expectMore`, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-4728631214
Thanks for the explanation! The "at most 2 crossing leaves" argument holds for 1D. However, `PointRangeQuery` supports up to 8 dimensions, where the number of crossing leaves can grow significantly. Did you run benchmarks for multi-dimensional cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "kkewwei (via GitHub)" <gi...@apache.org>.
kkewwei commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5339094239
@gf2121 Very thank you for the review.
`BulkAdder#grow` currently also increments the counter, so reusing it for capacity growth would affect the counter unless we add a parameter to disable it. Introducing such a parameter would require changing a broader set of callers. Given that, I think adding a dedicated method keeps the behavior explicit and minimizes the scope of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5518543158
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "gf2121 (via GitHub)" <gi...@apache.org>.
gf2121 commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5338151343
Thanks @kkewwei, The first time I saw this idea was here (https://github.com/apache/lucene/pull/14365#issuecomment-2736720587), and it makes sense to me. I wonder if we could borrow the approach in the comment — growing the estimated point count via the bulk adder (BulkAdder#grow) to upgrade to a bitset eagerly instead of introducing a new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "gf2121 (via GitHub)" <gi...@apache.org>.
gf2121 merged PR #16089:
URL: https://github.com/apache/lucene/pull/16089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5219844236
@kkewwei the plan sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5252249645
Thanks for adding and running the tests @kkewwei - great results!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade DocIdSetBuilder to use FixedBitSet eagerly once exceeding the threshold [lucene]
Posted by "kkewwei (via GitHub)" <gi...@apache.org>.
kkewwei commented on PR #16089:
URL: https://github.com/apache/lucene/pull/16089#issuecomment-5288919538
@epotyom Can you help merge in your spare time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org