You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "leoyvens (via GitHub)" <gi...@apache.org> on 2024/11/14 16:36:18 UTC

[PR] Have DefaultTableSource return the correct TableType [datafusion]

leoyvens opened a new pull request, #13416:
URL: https://github.com/apache/datafusion/pull/13416

   ## What changes are included in this PR?
   
   Fixes a tiny bug where `DefaultTableSource::table_type` would always return `TableType::Base` regardless of the actual table type of the provider.
   
   ## Are these changes tested?
   
   Yes there is a unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Have DefaultTableSource return the correct TableType [datafusion]

Posted by "goldmedal (via GitHub)" <gi...@apache.org>.
goldmedal commented on PR #13416:
URL: https://github.com/apache/datafusion/pull/13416#issuecomment-2477778688

   Thanks @leoyvens and @alamb for reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Have DefaultTableSource return the correct TableType [datafusion]

Posted by "goldmedal (via GitHub)" <gi...@apache.org>.
goldmedal merged PR #13416:
URL: https://github.com/apache/datafusion/pull/13416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org