You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/02/14 15:28:50 UTC
[GitHub] [commons-vfs] moikeygraham opened a new pull request #82: VFS-257 -
FTP: Add support for MDTM to get more accurate last modified times
moikeygraham opened a new pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times
URL: https://github.com/apache/commons-vfs/pull/82
Adding support for MDTM command when obtaining a FtpFileObject timestamp.
The patch attached on the original JIRA was quite old, so I started fresh.
Contains two test cases:
- Server supporting MDTM command
- Server not supporting MDTM command
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on a change in pull request
#82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified
times
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times
URL: https://github.com/apache/commons-vfs/pull/82#discussion_r379518076
##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java
##########
@@ -69,5 +69,8 @@ default void setBufferSize(final int bufferSize) throws FileSystemException {
}
OutputStream storeFileStream(String relPath) throws IOException;
-
+
+ boolean features() throws IOException;
Review comment:
Hi @moikeygraham,
- Thank you your PR.
- You MUST use default methods to provide binary backward compatibility.
- Please provide Javadocs for new methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] moikeygraham commented on a change in pull request
#82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified
times
Posted by GitBox <gi...@apache.org>.
moikeygraham commented on a change in pull request #82: VFS-257 - FTP: Add support for MDTM to get more accurate last modified times
URL: https://github.com/apache/commons-vfs/pull/82#discussion_r380068471
##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpClient.java
##########
@@ -69,5 +69,8 @@ default void setBufferSize(final int bufferSize) throws FileSystemException {
}
OutputStream storeFileStream(String relPath) throws IOException;
-
+
+ boolean features() throws IOException;
Review comment:
@garydgregory thanks for the prompt review!
I have made the changes you suggested in latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services