You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/27 04:06:58 UTC
[GitHub] [skywalking] wind2008hxy opened a new pull request #4579: should
set the trustStorePath default value empty
wind2008hxy opened a new pull request #4579: should set the trustStorePath default value empty
URL: https://github.com/apache/skywalking/pull/4579
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
when I set the elastic username & password, but not use ssl connect.
when I review the code,they are all right.
https://github.com/apache/skywalking/blob/c2e2d4182d5715cce49b6f95670f3fae2f44d0ba/oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java#L144
https://github.com/apache/skywalking/blob/c2e2d4182d5715cce49b6f95670f3fae2f44d0ba/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchProvider.java#L212
- How to fix?
the problem is the `application.yml` set the
```
trustStorePath: ${SW_SW_STORAGE_ES_SSL_JKS_PATH:"../es_keystore.jks"}
```
so you should set the trustStorePath default value empty
```
version: '3.3'
services:
elasticsearch:
image: docker.elastic.co/elasticsearch/elasticsearch:6.8.1
container_name: elasticsearch
restart: always
ports:
- 9200:9200
environment:
discovery.type: single-node
ELASTIC_PASSWORD: test
ulimits:
memlock:
soft: -1
hard: -1
oap:
image: apache/skywalking-oap-server:7.0.0-es6
container_name: oap
depends_on:
- elasticsearch
links:
- elasticsearch
restart: always
ports:
- 11800:11800
- 12800:12800
environment:
SW_STORAGE: elasticsearch
SW_NAMESPACE: sk
SW_STORAGE_ES_CLUSTER_NODES: elasticsearch:9200
SW_ES_USER: elastic
SW_ES_PASSWORD: test
SW_SW_STORAGE_ES_SSL_JKS_PATH: "" # this not work
# volumes:
# - ./application.yml:/skywalking/config/application.yml
ui:
image: apache/skywalking-ui:7.0.0
container_name: ui
depends_on:
- oap
links:
- oap
restart: always
ports:
- 8080:8080
environment:
SW_OAP_ADDRESS: oap:12800
```
Now I modify the `application.yml` set the trustStorePath default value empty.
```
trustStorePath: ${SW_SW_STORAGE_ES_SSL_JKS_PATH:""}
```
It work.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4579: Set the
trustStorePath default value to empty
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4579: Set the trustStorePath default value to empty
URL: https://github.com/apache/skywalking/pull/4579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4579: should set the
trustStorePath default value empty
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4579: should set the trustStorePath default value empty
URL: https://github.com/apache/skywalking/pull/4579#issuecomment-604813744
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=h1) Report
> Merging [#4579](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/54d8c95cf25e7a92ca2fcae068b48e995f8fc52f&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4579 +/- ##
==========================================
- Coverage 26.01% 25.99% -0.03%
==========================================
Files 1250 1250
Lines 29071 29071
Branches 3990 3990
==========================================
- Hits 7562 7556 -6
- Misses 20815 20822 +7
+ Partials 694 693 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4579/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4579/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `27.95% <0.00%> (+1.07%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=footer). Last update [54d8c95...a558fe4](https://codecov.io/gh/apache/skywalking/pull/4579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services