You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by de...@willem.engen.nl on 2018/07/04 12:40:28 UTC
Review request: AllowedSchemes for iOS
Hi,
I've been using Cordova for quite a while, here and there, and find the
recently introduced AllowedSchemes feature (CB-14013
<https://issues.apache.org/jira/browse/CB-14013>) very useful. Since it
is for Android only right now, I've written an iOS implementation. I
would be happy to receive feedback, and hope this is welcome to be
integrated into a future release.
https://github.com/apache/cordova-plugin-inappbrowser/pull/274
https://issues.apache.org/jira/browse/CB-14187
After this I plan to add some documentation for the feature (there's no
documentation yet), and rewrite url detection for CB-14188
<https://issues.apache.org/jira/browse/CB-14188> to accept "https?"
links as well, which I'm curious to hear if you agree that would be an
enhancement.
Kind regards,
- Willem
Re: Review request: AllowedSchemes for iOS
Posted by de...@willem.engen.nl.
Hi Chris, thank you for your response! I'll be happy to exercise some
patience.
In the meantime I've submitted a PR introducing callback event to
determine whether a URL to-be-loaded should be loaded or not:
https://github.com/apache/cordova-plugin-inappbrowser/pull/276
https://issues.apache.org/jira/browse/CB-14188
Looking forward to getting the changes reviewed.
Kind regards,
- Willem
On 2018/07/08 14:09:25, Chris Brody <c....@gmail.com> wrote:
> Thanks Willem for what looks like a really awesome contribution. Due>
> to my inexperience with that plugin and my current backlog I will>
> probably need a few weeks to look at that one. I am very hopeful that>
> the right expert can review it sooner.>
>
> Please feel free to followup with us if you do not hear back soon.>
> On Fri, Jul 6, 2018 at 10:52 PM <de...@willem.engen.nl> wrote:>
> >>
> > Hi,>
> >>
> > I've been using Cordova for quite a while, here and there, and find
the>
> > recently introduced AllowedSchemes feature (CB-14013>
> > <https://issues.apache.org/jira/browse/CB-14013>) very useful. Since
it>
> > is for Android only right now, I've written an iOS implementation. I>
> > would be happy to receive feedback, and hope this is welcome to be>
> > integrated into a future release.>
> >>
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/274>
> > https://issues.apache.org/jira/browse/CB-14187>
> >>
> > After this I plan to add some documentation for the feature (there's
no>
> > documentation yet), and rewrite url detection for CB-14188>
> > <https://issues.apache.org/jira/browse/CB-14188> to accept "https?">
> > links as well, which I'm curious to hear if you agree that would be an>
> > enhancement.>
> >>
> > Kind regards,>
> > - Willem>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Review request: AllowedSchemes for iOS
Posted by Chris Brody <ch...@gmail.com>.
Thanks Willem for what looks like a really awesome contribution. Due
to my inexperience with that plugin and my current backlog I will
probably need a few weeks to look at that one. I am very hopeful that
the right expert can review it sooner.
Please feel free to followup with us if you do not hear back soon.
On Fri, Jul 6, 2018 at 10:52 PM <de...@willem.engen.nl> wrote:
>
> Hi,
>
> I've been using Cordova for quite a while, here and there, and find the
> recently introduced AllowedSchemes feature (CB-14013
> <https://issues.apache.org/jira/browse/CB-14013>) very useful. Since it
> is for Android only right now, I've written an iOS implementation. I
> would be happy to receive feedback, and hope this is welcome to be
> integrated into a future release.
>
> https://github.com/apache/cordova-plugin-inappbrowser/pull/274
> https://issues.apache.org/jira/browse/CB-14187
>
> After this I plan to add some documentation for the feature (there's no
> documentation yet), and rewrite url detection for CB-14188
> <https://issues.apache.org/jira/browse/CB-14188> to accept "https?"
> links as well, which I'm curious to hear if you agree that would be an
> enhancement.
>
> Kind regards,
> - Willem
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org