You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/04/23 18:36:07 UTC
[GitHub] [zeppelin] alexott commented on a change in pull request #3742: [ZEPPELIN-4764]. Support real time dashboard for jdbc interpreter
alexott commented on a change in pull request #3742:
URL: https://github.com/apache/zeppelin/pull/3742#discussion_r414029011
##########
File path: jdbc/pom.xml
##########
@@ -33,6 +33,144 @@
<version>0.9.0-SNAPSHOT</version>
<name>Zeppelin: JDBC interpreter</name>
+ <properties>
+ <!--library versions-->
+ <interpreter.name>jdbc</interpreter.name>
+ <postgresql.version>9.4-1201-jdbc41</postgresql.version>
+ <hadoop.common.version>2.7.2</hadoop.common.version>
+ <h2.version>1.4.190</h2.version>
+ <commons.dbcp2.version>2.0.1</commons.dbcp2.version>
Review comment:
why do we use version that is released in 2014th? Maybe it makes sense to upgrade to some later version?
##########
File path: jdbc/pom.xml
##########
@@ -33,6 +33,144 @@
<version>0.9.0-SNAPSHOT</version>
<name>Zeppelin: JDBC interpreter</name>
+ <properties>
+ <!--library versions-->
+ <interpreter.name>jdbc</interpreter.name>
+ <postgresql.version>9.4-1201-jdbc41</postgresql.version>
+ <hadoop.common.version>2.7.2</hadoop.common.version>
+ <h2.version>1.4.190</h2.version>
+ <commons.dbcp2.version>2.0.1</commons.dbcp2.version>
+
+ <!--test library versions-->
+ <mockrunner.jdbc.version>1.0.8</mockrunner.jdbc.version>
+ </properties>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>${postgresql.version}</version>
Review comment:
should it have `test` scope as well? Why we need specific JDBC artifact in Zeppelin itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org