[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #947: MINIFICPP-1401 Read certificates from the Windows system store

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535137971



##########
File path: libminifi/src/utils/tls/WindowsCertStoreLocation.cpp
##########
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifdef WIN32
+
+#include "utils/tls/WindowsCertStoreLocation.h"
+
+#include <wincrypt.h>
+
+#include <array>
+#include <utility>
+
+#pragma comment(lib, "crypt32.lib")
+#pragma comment(lib, "Ws2_32.lib")
+
+namespace {
+
+constexpr std::array<std::pair<const char*, DWORD>, 8> SYSTEM_STORE_LOCATIONS{{

Review comment:
       Is there any reason using std::pair here but using a custom struct KeyValuePair in ExtendedKeyUsage? It just tickles my OCD :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org