You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/10 00:16:57 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #859: fix: ApisixClusterConfig e2e test case
tao12345666333 opened a new pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859
* pin the image of APISIX to stable version
* using the new plugin list API
* fix ApisixClusterConfig status logic
Signed-off-by: Jintao Zhang <zh...@gmail.com>
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
fix: #857
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859#issuecomment-1038529510
ping @tokers @gxthrj PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859#discussion_r803200015
##########
File path: Makefile
##########
@@ -87,8 +87,8 @@ endif
.PHONY: push-images-to-kind
push-images-to-kind: kind-up
ifeq ($(E2E_SKIP_BUILD), 0)
- docker pull apache/apisix:dev
- docker tag apache/apisix:dev $(LOCAL_REGISTRY)/apache/apisix:dev
+ docker pull apache/apisix:2.12.0-alpine
+ docker tag apache/apisix:2.12.0-alpine $(LOCAL_REGISTRY)/apache/apisix:dev
Review comment:
Will rollback to stable version before confirming that dev is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859#issuecomment-1038529510
ping @tokers @gxthrj PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859#issuecomment-1038537466
> ping @tokers @gxthrj PTAL, thanks!
Approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #859: fix: ApisixClusterConfig e2e test case
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #859:
URL: https://github.com/apache/apisix-ingress-controller/pull/859#issuecomment-1038537466
> ping @tokers @gxthrj PTAL, thanks!
Approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org