You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/09 16:01:54 UTC
[kudu-CR] [docker] Fix docker build
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15388
Change subject: [docker] Fix docker build
......................................................................
[docker] Fix docker build
This patch fixes the docker build by moving the `java` directory
`COPY` above the C++ build. This is neccessary now that the
subprocessor depends on the Java build.
I also added a missing label, `vcs-ref`, back to the kudu-python
image and made the kudu-python image a default target given
we want to publish it with each release.
Change-Id: Ifbf32dc0c803b3a1ab44724d45dd1e64728d6133
---
M docker/Dockerfile
M docker/bootstrap-python-env.sh
M docker/docker-build.sh
3 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/15388/1
--
To view, visit http://gerrit.cloudera.org:8080/15388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbf32dc0c803b3a1ab44724d45dd1e64728d6133
Gerrit-Change-Number: 15388
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Fix docker build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15388 )
Change subject: [docker] Fix docker build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbf32dc0c803b3a1ab44724d45dd1e64728d6133
Gerrit-Change-Number: 15388
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Mar 2020 18:59:28 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Fix docker build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15388 )
Change subject: [docker] Fix docker build
......................................................................
[docker] Fix docker build
This patch fixes the docker build by moving the `java` directory
`COPY` above the C++ build. This is neccessary now that the
subprocessor depends on the Java build.
I also added a missing label, `vcs-ref`, back to the kudu-python
image and made the kudu-python image a default target given
we want to publish it with each release.
Change-Id: Ifbf32dc0c803b3a1ab44724d45dd1e64728d6133
Reviewed-on: http://gerrit.cloudera.org:8080/15388
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docker/Dockerfile
M docker/bootstrap-python-env.sh
M docker/docker-build.sh
3 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbf32dc0c803b3a1ab44724d45dd1e64728d6133
Gerrit-Change-Number: 15388
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)