You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/09/07 09:06:59 UTC

[GitHub] [orc] nehaljwani commented on a change in pull request #541: Partially rework cmake modules to accommodate library types

nehaljwani commented on a change in pull request #541:
URL: https://github.com/apache/orc/pull/541#discussion_r484296933



##########
File path: c++/src/CMakeLists.txt
##########
@@ -236,11 +231,11 @@ endif(BUILD_LIBHDFSPP)
 add_library (orc STATIC ${SOURCE_FILES})
 
 target_link_libraries (orc
-  protobuf
-  zlib
-  snappy
-  lz4
-  zstd
+  orc::protobuf

Review comment:
       Because of it being an alias, I have to use some prefix. Doesn't have to be orc::, could be 3rdparty:: as well, or if you have something better in mind. I am deliberately using an alias target here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org