You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2008/11/01 16:24:34 UTC
Re: Element filter on list form
IMO having it in XSD add something important : documentation. It allows also to generate directly in XML, or whatnot, if we
want/need
If nobody see a problem with that I will commit Nicolas Patch (reviewed and tested : works well)
https://issues.apache.org/jira/browse/OFBIZ-2032
Note that Scott's solution will still be available ...
Jacques
From: "Malin Nicolas" <ma...@librenberry.net>
> Hi Scott,
>
> Yes it's possible to extend the ModelForm to look if exist a styleName in context.
>
> I don't know if the better solution is to use the set element and create the conditionnal with the result style in value attribute
> or dedicate element with separate conditionnal and style.
>
> An other solution is put the filter element in child of row-action ?
>
> Nicolas
>
> Scott Gray a écrit :
>> Can't the same thing be achieved by doing something like this:
>> <row-actions>
>> <set field="styleName" value="${bsh:productHeight == null
>> || productHeight == 0 ? 'warningRow' : 'normalRow'}"/>
>> </row-actions>
>>
>> Regards
>> Scott
>>
>> 2008/10/30 Malin Nicolas <ma...@librenberry.net>:
>>
>>> Hi,
>>>
>>> I have an other enchancement for the Screen Engine.
>>> When you have a list with many information, many user like to have some
>>> line with different color to look quickly important information.
>>>
>>> example : set line in blue when status order is created or line in red
>>> if order amount is greater than 10000
>>>
>>> An other example, for the project with Decathlon we use this :
>>>
>>> <form name="ListReceiveInCrowd" target="ReceiveInCrowd"
>>> paginate-target="ReceiveInCrowdSelection" type="multi"
>>> list-name="listIt" paginate="true">
>>> <row-actions>
>>> <entity-one entity-name="Product"
>>> value-name="product"></entity-one>
>>> </row-actions>
>>> <filter use-when="productHeight == null || productHeight == 0
>>> || productWidth == null || productWidth == 0 || productDepth ==
>>> null || productDepth == 0 || weight == null || weight == 0"
>>> style="warningRow"/>
>>> <field name="facilityId">...
>>> ...
>>> </form>
>>>
>>> The goal is show receipt with a product that have missing information on
>>> his measures and put the line in red. You can see the screenshot to
>>> http://librenberry.librenberry.net/Capture.png for
>>> visual result ;) .
>>>
>>> To do that, we create new element Filter associate to a form that take a
>>> use-when condition and if is true apply the style define in attribute.
>>>
>>> Do you have concerned by this features or do you have some suggestions ?
>>>
>>> Nicolas
>>>
>>> --
>>> Nicolas MALIN
>>> Consultant
>>> Tél : 06.17.66.40.06
>>> Site projet : http://www.neogia.org/
>>> -------
>>> Société LibrenBerry
>>> Tél : 02.48.02.56.12
>>> Site : http://www.librenberry.net/
>>>
>>>
>>>
>>>
>>>
>>
>>
>
>
> --
> Nicolas MALIN
> Consultant
> Tél : 06.17.66.40.06
> Site projet : http://www.neogia.org/
> -------
> Société LibrenBerry
> Tél : 02.48.02.56.12
> Site : http://www.librenberry.net/
>
Re: Element filter on list form
Posted by David E Jones <jo...@hotwaxmedia.com>.
Sounds good Nicolas. Looking forward to seeing you in New Orleans.
-David
On Nov 1, 2008, at 6:26 PM, mnicolas wrote:
> +1
>
> I agree also, my choise "filter" is stupid, if the element name is
> ok, I correct the patch. But can't do this now because I take the
> plane in few hours for the apache conf.
>
> I correct it when I will present in new orleans ;)
>
> Nicolas
>
> David E Jones a écrit :
>>
>> I agree, "filter" doesn't make any sense, or at least I don't
>> understand how the word "filter" has anything to do with the
>> functionality described.
>>
>> The qualification for a good name goes beyond that too, it can't
>> just have something to do with the functionality, it should
>> describe the functionality. The "alt-row-style" suggestion sounds
>> fine to me.
>>
>> -David
>>
>>
>> On Nov 1, 2008, at 2:47 PM, Scott Gray wrote:
>>
>>> Hi Jacques
>>>
>>> I realise now that using set wouldn't solve the problem because
>>> there
>>> is nowhere to set the row style. I still don't like the name
>>> "filter"
>>> though, I think something like alt-row-style would be more intuitive
>>> and would follow alt-target which performs a similar function.
>>>
>>> Regards
>>> Scott
>>>
>>> 2008/11/2 Jacques Le Roux <ja...@les7arts.com>:
>>>> IMO having it in XSD add something important : documentation. It
>>>> allows also
>>>> to generate directly in XML, or whatnot, if we want/need
>>>> If nobody see a problem with that I will commit Nicolas Patch
>>>> (reviewed and
>>>> tested : works well)
>>>> https://issues.apache.org/jira/browse/OFBIZ-2032
>>>> Note that Scott's solution will still be available ...
>>>>
>>>> Jacques
>>>>
>>>> From: "Malin Nicolas" <ma...@librenberry.net>
>>>>>
>>>>> Hi Scott,
>>>>>
>>>>> Yes it's possible to extend the ModelForm to look if exist a
>>>>> styleName in
>>>>> context.
>>>>>
>>>>> I don't know if the better solution is to use the set element
>>>>> and create
>>>>> the conditionnal with the result style in value attribute or
>>>>> dedicate
>>>>> element with separate conditionnal and style.
>>>>>
>>>>> An other solution is put the filter element in child of row-
>>>>> action ?
>>>>>
>>>>> Nicolas
>>>>>
>>>>> Scott Gray a écrit :
>>>>>>
>>>>>> Can't the same thing be achieved by doing something like this:
>>>>>> <row-actions>
>>>>>> <set field="styleName" value="${bsh:productHeight ==
>>>>>> null
>>>>>> || productHeight == 0 ? 'warningRow' : 'normalRow'}"/>
>>>>>> </row-actions>
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>>
>>>>>> 2008/10/30 Malin Nicolas <ma...@librenberry.net>:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have an other enchancement for the Screen Engine.
>>>>>>> When you have a list with many information, many user like to
>>>>>>> have some
>>>>>>> line with different color to look quickly important information.
>>>>>>>
>>>>>>> example : set line in blue when status order is created or
>>>>>>> line in red
>>>>>>> if order amount is greater than 10000
>>>>>>>
>>>>>>> An other example, for the project with Decathlon we use this :
>>>>>>>
>>>>>>> <form name="ListReceiveInCrowd" target="ReceiveInCrowd"
>>>>>>> paginate-target="ReceiveInCrowdSelection" type="multi"
>>>>>>> list-name="listIt" paginate="true">
>>>>>>> <row-actions>
>>>>>>> <entity-one entity-name="Product"
>>>>>>> value-name="product"></entity-one>
>>>>>>> </row-actions>
>>>>>>> <filter use-when="productHeight == null || productHeight
>>>>>>> == 0
>>>>>>> || productWidth == null || productWidth == 0 ||
>>>>>>> productDepth ==
>>>>>>> null || productDepth == 0 || weight == null || weight == 0"
>>>>>>> style="warningRow"/>
>>>>>>> <field name="facilityId">...
>>>>>>> ...
>>>>>>> </form>
>>>>>>>
>>>>>>> The goal is show receipt with a product that have missing
>>>>>>> information on
>>>>>>> his measures and put the line in red. You can see the
>>>>>>> screenshot to
>>>>>>> http://librenberry.librenberry.net/Capture.png for
>>>>>>> visual result ;) .
>>>>>>>
>>>>>>> To do that, we create new element Filter associate to a form
>>>>>>> that take a
>>>>>>> use-when condition and if is true apply the style define in
>>>>>>> attribute.
>>>>>>>
>>>>>>> Do you have concerned by this features or do you have some
>>>>>>> suggestions ?
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>> --
>>>>>>> Nicolas MALIN
>>>>>>> Consultant
>>>>>>> Tél : 06.17.66.40.06
>>>>>>> Site projet : http://www.neogia.org/
>>>>>>> -------
>>>>>>> Société LibrenBerry
>>>>>>> Tél : 02.48.02.56.12
>>>>>>> Site : http://www.librenberry.net/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Nicolas MALIN
>>>>> Consultant
>>>>> Tél : 06.17.66.40.06
>>>>> Site projet : http://www.neogia.org/
>>>>> -------
>>>>> Société LibrenBerry
>>>>> Tél : 02.48.02.56.12
>>>>> Site : http://www.librenberry.net/
>>>>>
>>>>
>>>>
>>
>>
>
Re: Element filter on list form
Posted by mnicolas <ma...@librenberry.net>.
+1
I agree also, my choise "filter" is stupid, if the element name is ok, I
correct the patch. But can't do this now because I take the plane in few
hours for the apache conf.
I correct it when I will present in new orleans ;)
Nicolas
David E Jones a écrit :
>
> I agree, "filter" doesn't make any sense, or at least I don't
> understand how the word "filter" has anything to do with the
> functionality described.
>
> The qualification for a good name goes beyond that too, it can't just
> have something to do with the functionality, it should describe the
> functionality. The "alt-row-style" suggestion sounds fine to me.
>
> -David
>
>
> On Nov 1, 2008, at 2:47 PM, Scott Gray wrote:
>
>> Hi Jacques
>>
>> I realise now that using set wouldn't solve the problem because there
>> is nowhere to set the row style. I still don't like the name "filter"
>> though, I think something like alt-row-style would be more intuitive
>> and would follow alt-target which performs a similar function.
>>
>> Regards
>> Scott
>>
>> 2008/11/2 Jacques Le Roux <ja...@les7arts.com>:
>>> IMO having it in XSD add something important : documentation. It
>>> allows also
>>> to generate directly in XML, or whatnot, if we want/need
>>> If nobody see a problem with that I will commit Nicolas Patch
>>> (reviewed and
>>> tested : works well)
>>> https://issues.apache.org/jira/browse/OFBIZ-2032
>>> Note that Scott's solution will still be available ...
>>>
>>> Jacques
>>>
>>> From: "Malin Nicolas" <ma...@librenberry.net>
>>>>
>>>> Hi Scott,
>>>>
>>>> Yes it's possible to extend the ModelForm to look if exist a
>>>> styleName in
>>>> context.
>>>>
>>>> I don't know if the better solution is to use the set element and
>>>> create
>>>> the conditionnal with the result style in value attribute or dedicate
>>>> element with separate conditionnal and style.
>>>>
>>>> An other solution is put the filter element in child of row-action ?
>>>>
>>>> Nicolas
>>>>
>>>> Scott Gray a écrit :
>>>>>
>>>>> Can't the same thing be achieved by doing something like this:
>>>>> <row-actions>
>>>>> <set field="styleName" value="${bsh:productHeight == null
>>>>> || productHeight == 0 ? 'warningRow' : 'normalRow'}"/>
>>>>> </row-actions>
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> 2008/10/30 Malin Nicolas <ma...@librenberry.net>:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have an other enchancement for the Screen Engine.
>>>>>> When you have a list with many information, many user like to
>>>>>> have some
>>>>>> line with different color to look quickly important information.
>>>>>>
>>>>>> example : set line in blue when status order is created or line
>>>>>> in red
>>>>>> if order amount is greater than 10000
>>>>>>
>>>>>> An other example, for the project with Decathlon we use this :
>>>>>>
>>>>>> <form name="ListReceiveInCrowd" target="ReceiveInCrowd"
>>>>>> paginate-target="ReceiveInCrowdSelection" type="multi"
>>>>>> list-name="listIt" paginate="true">
>>>>>> <row-actions>
>>>>>> <entity-one entity-name="Product"
>>>>>> value-name="product"></entity-one>
>>>>>> </row-actions>
>>>>>> <filter use-when="productHeight == null || productHeight == 0
>>>>>> || productWidth == null || productWidth == 0 || productDepth ==
>>>>>> null || productDepth == 0 || weight == null || weight == 0"
>>>>>> style="warningRow"/>
>>>>>> <field name="facilityId">...
>>>>>> ...
>>>>>> </form>
>>>>>>
>>>>>> The goal is show receipt with a product that have missing
>>>>>> information on
>>>>>> his measures and put the line in red. You can see the screenshot to
>>>>>> http://librenberry.librenberry.net/Capture.png for
>>>>>> visual result ;) .
>>>>>>
>>>>>> To do that, we create new element Filter associate to a form that
>>>>>> take a
>>>>>> use-when condition and if is true apply the style define in
>>>>>> attribute.
>>>>>>
>>>>>> Do you have concerned by this features or do you have some
>>>>>> suggestions ?
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>> --
>>>>>> Nicolas MALIN
>>>>>> Consultant
>>>>>> Tél : 06.17.66.40.06
>>>>>> Site projet : http://www.neogia.org/
>>>>>> -------
>>>>>> Société LibrenBerry
>>>>>> Tél : 02.48.02.56.12
>>>>>> Site : http://www.librenberry.net/
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Nicolas MALIN
>>>> Consultant
>>>> Tél : 06.17.66.40.06
>>>> Site projet : http://www.neogia.org/
>>>> -------
>>>> Société LibrenBerry
>>>> Tél : 02.48.02.56.12
>>>> Site : http://www.librenberry.net/
>>>>
>>>
>>>
>
>
Re: Element filter on list form
Posted by David E Jones <jo...@hotwaxmedia.com>.
I agree, "filter" doesn't make any sense, or at least I don't
understand how the word "filter" has anything to do with the
functionality described.
The qualification for a good name goes beyond that too, it can't just
have something to do with the functionality, it should describe the
functionality. The "alt-row-style" suggestion sounds fine to me.
-David
On Nov 1, 2008, at 2:47 PM, Scott Gray wrote:
> Hi Jacques
>
> I realise now that using set wouldn't solve the problem because there
> is nowhere to set the row style. I still don't like the name "filter"
> though, I think something like alt-row-style would be more intuitive
> and would follow alt-target which performs a similar function.
>
> Regards
> Scott
>
> 2008/11/2 Jacques Le Roux <ja...@les7arts.com>:
>> IMO having it in XSD add something important : documentation. It
>> allows also
>> to generate directly in XML, or whatnot, if we want/need
>> If nobody see a problem with that I will commit Nicolas Patch
>> (reviewed and
>> tested : works well)
>> https://issues.apache.org/jira/browse/OFBIZ-2032
>> Note that Scott's solution will still be available ...
>>
>> Jacques
>>
>> From: "Malin Nicolas" <ma...@librenberry.net>
>>>
>>> Hi Scott,
>>>
>>> Yes it's possible to extend the ModelForm to look if exist a
>>> styleName in
>>> context.
>>>
>>> I don't know if the better solution is to use the set element and
>>> create
>>> the conditionnal with the result style in value attribute or
>>> dedicate
>>> element with separate conditionnal and style.
>>>
>>> An other solution is put the filter element in child of row-action ?
>>>
>>> Nicolas
>>>
>>> Scott Gray a écrit :
>>>>
>>>> Can't the same thing be achieved by doing something like this:
>>>> <row-actions>
>>>> <set field="styleName" value="${bsh:productHeight == null
>>>> || productHeight == 0 ? 'warningRow' : 'normalRow'}"/>
>>>> </row-actions>
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> 2008/10/30 Malin Nicolas <ma...@librenberry.net>:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have an other enchancement for the Screen Engine.
>>>>> When you have a list with many information, many user like to
>>>>> have some
>>>>> line with different color to look quickly important information.
>>>>>
>>>>> example : set line in blue when status order is created or line
>>>>> in red
>>>>> if order amount is greater than 10000
>>>>>
>>>>> An other example, for the project with Decathlon we use this :
>>>>>
>>>>> <form name="ListReceiveInCrowd" target="ReceiveInCrowd"
>>>>> paginate-target="ReceiveInCrowdSelection" type="multi"
>>>>> list-name="listIt" paginate="true">
>>>>> <row-actions>
>>>>> <entity-one entity-name="Product"
>>>>> value-name="product"></entity-one>
>>>>> </row-actions>
>>>>> <filter use-when="productHeight == null || productHeight
>>>>> == 0
>>>>> || productWidth == null || productWidth == 0 || productDepth
>>>>> ==
>>>>> null || productDepth == 0 || weight == null || weight == 0"
>>>>> style="warningRow"/>
>>>>> <field name="facilityId">...
>>>>> ...
>>>>> </form>
>>>>>
>>>>> The goal is show receipt with a product that have missing
>>>>> information on
>>>>> his measures and put the line in red. You can see the screenshot
>>>>> to
>>>>> http://librenberry.librenberry.net/Capture.png for
>>>>> visual result ;) .
>>>>>
>>>>> To do that, we create new element Filter associate to a form
>>>>> that take a
>>>>> use-when condition and if is true apply the style define in
>>>>> attribute.
>>>>>
>>>>> Do you have concerned by this features or do you have some
>>>>> suggestions ?
>>>>>
>>>>> Nicolas
>>>>>
>>>>> --
>>>>> Nicolas MALIN
>>>>> Consultant
>>>>> Tél : 06.17.66.40.06
>>>>> Site projet : http://www.neogia.org/
>>>>> -------
>>>>> Société LibrenBerry
>>>>> Tél : 02.48.02.56.12
>>>>> Site : http://www.librenberry.net/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Nicolas MALIN
>>> Consultant
>>> Tél : 06.17.66.40.06
>>> Site projet : http://www.neogia.org/
>>> -------
>>> Société LibrenBerry
>>> Tél : 02.48.02.56.12
>>> Site : http://www.librenberry.net/
>>>
>>
>>
Re: Element filter on list form
Posted by Scott Gray <le...@gmail.com>.
Hi Jacques
I realise now that using set wouldn't solve the problem because there
is nowhere to set the row style. I still don't like the name "filter"
though, I think something like alt-row-style would be more intuitive
and would follow alt-target which performs a similar function.
Regards
Scott
2008/11/2 Jacques Le Roux <ja...@les7arts.com>:
> IMO having it in XSD add something important : documentation. It allows also
> to generate directly in XML, or whatnot, if we want/need
> If nobody see a problem with that I will commit Nicolas Patch (reviewed and
> tested : works well)
> https://issues.apache.org/jira/browse/OFBIZ-2032
> Note that Scott's solution will still be available ...
>
> Jacques
>
> From: "Malin Nicolas" <ma...@librenberry.net>
>>
>> Hi Scott,
>>
>> Yes it's possible to extend the ModelForm to look if exist a styleName in
>> context.
>>
>> I don't know if the better solution is to use the set element and create
>> the conditionnal with the result style in value attribute or dedicate
>> element with separate conditionnal and style.
>>
>> An other solution is put the filter element in child of row-action ?
>>
>> Nicolas
>>
>> Scott Gray a écrit :
>>>
>>> Can't the same thing be achieved by doing something like this:
>>> <row-actions>
>>> <set field="styleName" value="${bsh:productHeight == null
>>> || productHeight == 0 ? 'warningRow' : 'normalRow'}"/>
>>> </row-actions>
>>>
>>> Regards
>>> Scott
>>>
>>> 2008/10/30 Malin Nicolas <ma...@librenberry.net>:
>>>
>>>> Hi,
>>>>
>>>> I have an other enchancement for the Screen Engine.
>>>> When you have a list with many information, many user like to have some
>>>> line with different color to look quickly important information.
>>>>
>>>> example : set line in blue when status order is created or line in red
>>>> if order amount is greater than 10000
>>>>
>>>> An other example, for the project with Decathlon we use this :
>>>>
>>>> <form name="ListReceiveInCrowd" target="ReceiveInCrowd"
>>>> paginate-target="ReceiveInCrowdSelection" type="multi"
>>>> list-name="listIt" paginate="true">
>>>> <row-actions>
>>>> <entity-one entity-name="Product"
>>>> value-name="product"></entity-one>
>>>> </row-actions>
>>>> <filter use-when="productHeight == null || productHeight == 0
>>>> || productWidth == null || productWidth == 0 || productDepth ==
>>>> null || productDepth == 0 || weight == null || weight == 0"
>>>> style="warningRow"/>
>>>> <field name="facilityId">...
>>>> ...
>>>> </form>
>>>>
>>>> The goal is show receipt with a product that have missing information on
>>>> his measures and put the line in red. You can see the screenshot to
>>>> http://librenberry.librenberry.net/Capture.png for
>>>> visual result ;) .
>>>>
>>>> To do that, we create new element Filter associate to a form that take a
>>>> use-when condition and if is true apply the style define in attribute.
>>>>
>>>> Do you have concerned by this features or do you have some suggestions ?
>>>>
>>>> Nicolas
>>>>
>>>> --
>>>> Nicolas MALIN
>>>> Consultant
>>>> Tél : 06.17.66.40.06
>>>> Site projet : http://www.neogia.org/
>>>> -------
>>>> Société LibrenBerry
>>>> Tél : 02.48.02.56.12
>>>> Site : http://www.librenberry.net/
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>> Nicolas MALIN
>> Consultant
>> Tél : 06.17.66.40.06
>> Site projet : http://www.neogia.org/
>> -------
>> Société LibrenBerry
>> Tél : 02.48.02.56.12
>> Site : http://www.librenberry.net/
>>
>
>