You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dennis Lundberg <de...@apache.org> on 2007/12/03 23:08:49 UTC
Re: svn commit: r599597 - in /maven/plugins/trunk/maven-pmd-plugin:
pom.xml src/main/java/org/apache/maven/plugin/pmd/CpdReport.java src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
Judging by the Continuum report, this is the check in that broke
maven-pmd-plugin. PMD 4.1 seems to be compiled with Java 1.5.
dkulp@apache.org wrote:
> Author: dkulp
> Date: Thu Nov 29 14:09:50 2007
> New Revision: 599597
>
> URL: http://svn.apache.org/viewvc?rev=599597&view=rev
> Log:
> [MPMD-59] Update to PMD 4.1 (patch from Xavier Le Vourch applied with other fixes needed)
>
> Modified:
> maven/plugins/trunk/maven-pmd-plugin/pom.xml
> maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java
> maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
> maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
>
> Modified: maven/plugins/trunk/maven-pmd-plugin/pom.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/pom.xml?rev=599597&r1=599596&r2=599597&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-pmd-plugin/pom.xml (original)
> +++ maven/plugins/trunk/maven-pmd-plugin/pom.xml Thu Nov 29 14:09:50 2007
> @@ -103,10 +103,9 @@
> <dependency>
> <groupId>pmd</groupId>
> <artifactId>pmd</artifactId>
> - <version>3.9</version>
> + <version>4.1</version>
> <exclusions>
> - <!-- 3.9 specifies a beta version of jaxen which doesn't have a pom resulting in
> - a warning whenever you use it. Likewise for xom 1.0. -->
> + <!-- incorrect jaxen version in pom for 4.1 -->
> <exclusion>
> <groupId>jaxen</groupId>
> <artifactId>jaxen</artifactId>
> @@ -116,18 +115,7 @@
> <dependency>
> <groupId>jaxen</groupId>
> <artifactId>jaxen</artifactId>
> - <version>1.1</version>
> - <exclusions>
> - <exclusion>
> - <groupId>xom</groupId>
> - <artifactId>xom</artifactId>
> - </exclusion>
> - </exclusions>
> - </dependency>
> - <dependency>
> - <groupId>xom</groupId>
> - <artifactId>xom</artifactId>
> - <version>1.1</version>
> + <version>1.1.1</version>
> </dependency>
> <dependency>
> <groupId>org.apache.maven.reporting</groupId>
>
> Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java?rev=599597&r1=599596&r2=599597&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java (original)
> +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java Thu Nov 29 14:09:50 2007
> @@ -182,7 +182,7 @@
> Renderer renderer = null;
> if ( "xml".equals( format ) )
> {
> - renderer = new XMLRenderer();
> + renderer = new XMLRenderer("UTF-8");
> }
> else if ( "csv".equals( format ) )
> {
>
> Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java?rev=599597&r1=599596&r2=599597&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java (original)
> +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java Thu Nov 29 14:09:50 2007
> @@ -257,7 +257,10 @@
>
> try
> {
> - r.render( stringwriter, report );
> + r.setWriter(stringwriter);
> + r.start();
> + r.renderFileReport(report);
> + r.end();
> String buffer = stringwriter.toString();
>
> Writer writer = new FileWriter( new File( targetDirectory, "pmd." + format ) );
>
> Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java?rev=599597&r1=599596&r2=599597&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java (original)
> +++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java Thu Nov 29 14:09:50 2007
> @@ -195,6 +195,7 @@
>
> CPD tCpd = new MockCpd( 100, new JavaLanguage(), tList.iterator() );
>
> + tCpd.go();
> mojo.writeNonHtml( tCpd );
>
> File tReport = new File( "target/test/unit/default-configuration/target/cpd.xml" );
>
>
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r599597 - in /maven/plugins/trunk/maven-pmd-plugin:
pom.xml src/main/java/org/apache/maven/plugin/pmd/CpdReport.java src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
Posted by Xavier Le Vourch <xa...@brittanysoftware.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
After discussing with Daniel Kulp over irc, I submitted a new bundle
upload request for pmd:pmd-jdk14 that should fix the problem. If that
works, both bundles will be created for future releases of pmd.
That new artifact adds extra dependencies on backport-util-concurrent
and retroweaver-rt.
Xavier
Xavier Le Vourch wrote:
> Dennis Lundberg wrote:
>> Judging by the Continuum report, this is the check in that broke
>> maven-pmd-plugin. PMD 4.1 seems to be compiled with Java 1.5.
>
>
>
> Yes, pmd 4.1 has been compiled with and requires java 1.5 to run (it was
> changed for pmd 4.0) but there is a 1.4 compatible version included in
> the release (in java14) that uses retroweaver to generate the jar files
> and also depends on the retroweaver runtime to run.
>
> Let me know if you want me to create a bundle for the pmd14-4.1.jar and
> how that should coexist with the 1.5 based version.
>
>
> Xavier
>
>
>> dkulp@apache.org wrote:
>>> Author: dkulp
>>> Date: Thu Nov 29 14:09:50 2007
>>> New Revision: 599597
>>>
>>> URL: http://svn.apache.org/viewvc?rev=599597&view=rev
>>> Log:
>>> [MPMD-59] Update to PMD 4.1 (patch from Xavier Le Vourch applied with
>>> other fixes needed)
>>>
>
>
>
- ---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
- --
Xavier Le Vourch
Brittany Software, Inc.
<xa...@brittanysoftware.com>
PGP Key (ID 0x896C5947): http://brittanysoftware.com/gpg_key.asc
Key fingerprint: 73B3 6370 B8C5 4325 F2D8 4115 0372 5805 896C 5947
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHVJMoA3JYBYlsWUcRAunuAJ0XROHq6+O1dYWjaMbeCbEf3R5FOACfWHkn
Ky6xOocg0BGkG4RpAE1WHGg=
=y6nJ
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r599597 - in /maven/plugins/trunk/maven-pmd-plugin:
pom.xml src/main/java/org/apache/maven/plugin/pmd/CpdReport.java src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
Posted by Xavier Le Vourch <xa...@brittanysoftware.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dennis Lundberg wrote:
> Judging by the Continuum report, this is the check in that broke
> maven-pmd-plugin. PMD 4.1 seems to be compiled with Java 1.5.
>
Yes, pmd 4.1 has been compiled with and requires java 1.5 to run (it was
changed for pmd 4.0) but there is a 1.4 compatible version included in
the release (in java14) that uses retroweaver to generate the jar files
and also depends on the retroweaver runtime to run.
Let me know if you want me to create a bundle for the pmd14-4.1.jar and
how that should coexist with the 1.5 based version.
Xavier
> dkulp@apache.org wrote:
>> Author: dkulp
>> Date: Thu Nov 29 14:09:50 2007
>> New Revision: 599597
>>
>> URL: http://svn.apache.org/viewvc?rev=599597&view=rev
>> Log:
>> [MPMD-59] Update to PMD 4.1 (patch from Xavier Le Vourch applied with
>> other fixes needed)
>>
- --
Xavier Le Vourch
Brittany Software, Inc.
<xa...@brittanysoftware.com>
PGP Key (ID 0x896C5947): http://brittanysoftware.com/gpg_key.asc
Key fingerprint: 73B3 6370 B8C5 4325 F2D8 4115 0372 5805 896C 5947
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHVICWA3JYBYlsWUcRAhfHAJ91MiWFyFzgLIqmQFYxFlwJZBCdEwCgoHPp
TTLY+3c0Fsygi2+RNImU/3g=
=iJEl
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org