You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2025/05/01 21:18:28 UTC
[PR] Only add the Apache Snapshot repository w/ grailsVersion is a SNAPSHOT [grails-forge]
jamesfredley opened a new pull request, #559:
URL: https://github.com/apache/grails-forge/pull/559
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT [grails-forge]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #559:
URL: https://github.com/apache/grails-forge/pull/559#discussion_r2071648264
##########
grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw:
##########
@@ -27,8 +28,9 @@ GradleBuild gradleBuild
buildscript {
repositories {
mavenCentral()
- // TODO: only include on when grailsVersion is a snapshot
+@if (grailsVersion.endsWith("SNAPSHOT")) {
maven { url "https://repository.apache.org/content/groups/snapshots/" }
Review Comment:
Does the `}` have to be on the next line due to the `@if` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT [grails-forge]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #559:
URL: https://github.com/apache/grails-forge/pull/559#discussion_r2071645347
##########
grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw:
##########
@@ -27,8 +28,9 @@ GradleBuild gradleBuild
buildscript {
repositories {
mavenCentral()
- // TODO: only include on when grailsVersion is a snapshot
+@if (grailsVersion.endsWith("SNAPSHOT")) {
maven { url "https://repository.apache.org/content/groups/snapshots/" }
Review Comment:
All cleaned up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT [grails-forge]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #559:
URL: https://github.com/apache/grails-forge/pull/559#discussion_r2071653402
##########
grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw:
##########
@@ -27,8 +28,9 @@ GradleBuild gradleBuild
buildscript {
repositories {
mavenCentral()
- // TODO: only include on when grailsVersion is a snapshot
+@if (grailsVersion.endsWith("SNAPSHOT")) {
maven { url "https://repository.apache.org/content/groups/snapshots/" }
Review Comment:
Yes, at least from an output formatting standpoint. Rocker is very literal about whitespace.
It might work moved up, but the output would be off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT [grails-forge]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #559:
URL: https://github.com/apache/grails-forge/pull/559#discussion_r2071229205
##########
grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw:
##########
@@ -27,8 +28,9 @@ GradleBuild gradleBuild
buildscript {
repositories {
mavenCentral()
- // TODO: only include on when grailsVersion is a snapshot
+@if (grailsVersion.endsWith("SNAPSHOT")) {
maven { url "https://repository.apache.org/content/groups/snapshots/" }
Review Comment:
Should we take this opportunity to use setter syntax for Gradle 9 compatibility?
`url = ` in all instances.
Also, can we clean up the trailing slash in the url?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT [grails-forge]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #559:
URL: https://github.com/apache/grails-forge/pull/559#discussion_r2071663597
##########
grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw:
##########
@@ -27,8 +28,9 @@ GradleBuild gradleBuild
buildscript {
repositories {
mavenCentral()
- // TODO: only include on when grailsVersion is a snapshot
+@if (grailsVersion.endsWith("SNAPSHOT")) {
maven { url "https://repository.apache.org/content/groups/snapshots/" }
Review Comment:
Here is the generated build.gradle based on this branch.
```
buildscript {
repositories {
mavenCentral()
maven { url = 'https://repository.apache.org/content/groups/snapshots' }
maven { url = 'https://repo.grails.org/grails/core' }
}
dependencies { // Not Published to Gradle Plugin Portal
classpath "com.bertramlabs.plugins:asset-pipeline-gradle"
classpath platform("org.apache.grails:grails-bom:$grailsVersion")
classpath "org.apache.grails:grails-data-hibernate5"
classpath "org.apache.grails:grails-gradle-plugins"
}
}
plugins {
id "groovy"
id "war"
id "idea"
id "eclipse"
}
// Not Published to Gradle Plugin Portal
apply plugin: "asset-pipeline"
apply plugin: "org.apache.grails.gradle.grails-web"
apply plugin: "org.apache.grails.gradle.grails-gsp"
group = "Test1"
repositories {
mavenCentral()
maven { url = 'https://repository.apache.org/content/groups/snapshots' }
maven { url = 'https://repo.grails.org/grails/core' }
}
dependencies {
profile "org.apache.grails.profiles:web"
developmentOnly "org.webjars.npm:bootstrap"
developmentOnly "org.webjars.npm:bootstrap-icons"
developmentOnly "org.webjars.npm:jquery"
implementation platform("org.apache.grails:grails-bom:$grailsVersion")
implementation "org.apache.grails:grails-core"
implementation "org.apache.grails:grails-data-hibernate5"
implementation "org.apache.grails:grails-databinding"
implementation "org.apache.grails:grails-gsp"
implementation "org.apache.grails:grails-i18n"
implementation "org.apache.grails:grails-interceptors"
implementation "org.apache.grails:grails-logging"
implementation "org.apache.grails:grails-rest-transforms"
implementation "org.apache.grails:grails-scaffolding"
implementation "org.apache.grails:grails-services"
implementation "org.apache.grails:grails-url-mappings"
implementation "org.apache.grails:grails-web-boot"
implementation "org.springframework.boot:spring-boot-autoconfigure"
implementation "org.springframework.boot:spring-boot-starter"
implementation "org.springframework.boot:spring-boot-starter-actuator"
implementation "org.springframework.boot:spring-boot-starter-logging"
implementation "org.springframework.boot:spring-boot-starter-tomcat"
implementation "org.springframework.boot:spring-boot-starter-validation"
console "org.apache.grails:grails-console"
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails"
runtimeOnly "com.h2database:h2"
runtimeOnly "com.zaxxer:HikariCP"
runtimeOnly "org.fusesource.jansi:jansi"
integrationTestImplementation testFixtures("org.apache.grails:grails-geb")
testImplementation "org.apache.grails:grails-testing-support-datamapping"
testImplementation "org.apache.grails:grails-testing-support-web"
testImplementation "org.spockframework:spock-core"
}
compileJava.options.release = 17
tasks.withType(Test) {
useJUnitPlatform()
}
assets {
excludes = [
'webjars/jquery/**',
'webjars/bootstrap/**',
'webjars/bootstrap-icons/**'
]
includes = [
'webjars/jquery/*/dist/jquery.js',
'webjars/bootstrap/*/dist/js/bootstrap.bundle.js',
'webjars/bootstrap/*/dist/css/bootstrap.css',
'webjars/bootstrap-icons/*/font/bootstrap-icons.css',
'webjars/bootstrap-icons/*/font/fonts/*',
]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT [grails-forge]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #559:
URL: https://github.com/apache/grails-forge/pull/559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org