You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/02/13 12:00:55 UTC

[GitHub] [tomcat] ThStock opened a new pull request #240: Added extension point for custom delta requests

ThStock opened a new pull request #240: Added extension point for custom delta requests
URL: https://github.com/apache/tomcat/pull/240
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] ChristopherSchultz merged pull request #240: Added extension point for custom delta requests

Posted by GitBox <gi...@apache.org>.
ChristopherSchultz merged pull request #240: Added extension point for custom delta requests
URL: https://github.com/apache/tomcat/pull/240
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] ThStock commented on a change in pull request #240: Added extension point for custom delta requests

Posted by GitBox <gi...@apache.org>.
ThStock commented on a change in pull request #240: Added extension point for custom delta requests
URL: https://github.com/apache/tomcat/pull/240#discussion_r379835476
 
 

 ##########
 File path: java/org/apache/catalina/ha/session/DeltaSession.java
 ##########
 @@ -106,7 +106,15 @@ public DeltaSession(Manager manager) {
         super(manager);
         boolean recordAllActions = manager instanceof ClusterManagerBase &&
                 ((ClusterManagerBase)manager).isRecordAllActions();
-        deltaRequest = new DeltaRequest(getIdInternal(), recordAllActions);
+        deltaRequest = newDeltaRequest(getIdInternal(), recordAllActions);
+    }
+
+    protected DeltaRequest newDeltaRequest() {
+        return new DeltaRequest();
 
 Review comment:
   What do you think, is the latest change acceptable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #240: Added extension point for custom delta requests

Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on a change in pull request #240: Added extension point for custom delta requests
URL: https://github.com/apache/tomcat/pull/240#discussion_r378902517
 
 

 ##########
 File path: java/org/apache/catalina/ha/session/DeltaSession.java
 ##########
 @@ -106,7 +106,15 @@ public DeltaSession(Manager manager) {
         super(manager);
         boolean recordAllActions = manager instanceof ClusterManagerBase &&
                 ((ClusterManagerBase)manager).isRecordAllActions();
-        deltaRequest = new DeltaRequest(getIdInternal(), recordAllActions);
+        deltaRequest = newDeltaRequest(getIdInternal(), recordAllActions);
+    }
+
+    protected DeltaRequest newDeltaRequest() {
+        return new DeltaRequest();
 
 Review comment:
   I might do:
   
   `return newDeltaRequest(null, false);`
   
   here instead of calling the constructor. This allows subclasses to simply override a single method. Or maybe just use the single method and pass-in `null/false` instead of having an overloaded no-arg method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org