[GitHub] cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

[GitBox <gi...@apache.org>]

cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436595682
 
 
   I think the parameters should either be part of the constructor or become an additional argument of the scan method. Right now, once you construct a scanner, it can be shared without side effects. With introducing a setter method for the properties, this changes and someone calling it can cause problems to another one using the same shared instance.
   As these properties influence the tasks which are set using the constructor I think the parameters should be come part of the constructor as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services