You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/06/18 13:56:53 UTC

[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #180: add build docs

mdedetrich commented on PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#issuecomment-1596156620

   @pjfanning So I haven't had proper time to check this, but the issue I am concerned about specifically is https://github.com/classgraph/classgraph/issues/403#issuecomment-586770739 and https://github.com/apache/incubator-pekko/pull/258/files#diff-c11a10bd9e773399e4272cd1ee5dff72545afb2f8bed23f2d1bbc49d4e1fc03fL60-L67 . JDK 9+ introduced a very subtle but possible breaking change from the JDK 8 standard library. If the problem is there, you won't hit at compile time, you hit them at runtime and only if you hit specific codepaths i.e. code that calls `byteBuffer.clear()` (and I briefly checked pekko-http and it does call this code).
   
   To confirm that there isn't a problem I have to manually inspect the bytecode, just like I did here https://github.com/apache/incubator-pekko/pull/258#issuecomment-1477908162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org