You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Rui Wang (Jira)" <ji...@apache.org> on 2020/12/07 02:15:00 UTC

[jira] [Commented] (RATIS-1115) NettyServerStreamRpc should handle duplicate headers

    [ https://issues.apache.org/jira/browse/RATIS-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244901#comment-17244901 ] 

Rui Wang commented on RATIS-1115:
---------------------------------

I thinks this JIRA is already solved by https://github.com/apache/incubator-ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java#L346

> NettyServerStreamRpc should handle duplicate headers
> ----------------------------------------------------
>
>                 Key: RATIS-1115
>                 URL: https://issues.apache.org/jira/browse/RATIS-1115
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>
> Current server does 
>  
> {code:java}
> if (Header) {    
>   streams.computeIfAbsent(request.getStreamId(), id ->createStream());
>   ...  
> }
> {code}
>  
>  
> It is possible that clients send multiple headers so the entry already exists. We might choose to send a reply with error message without accepting duplicated headers. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)