You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/07 11:30:06 UTC
[GitHub] [incubator-doris] zhannngchen opened a new pull request, #8903: [improvement](log) make compaction no suitable version log more friendly
zhannngchen opened a new pull request, #8903:
URL: https://github.com/apache/incubator-doris/pull/8903
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
[#8781](https://github.com/apache/incubator-doris/pull/8781) fixed a bug of compaction log, so that any failure of compaction submission will trigger a warning log.
But in the most time, the compaction submission failure is caused by "no suite version", which is a common case.
User may feel anxious when they found lots of logs like the following
```
W0406 17:42:17.825480 42660 olap_server.cpp:402] failed to submit compaction task for tablet: 10128, err: failed to prepare compaction task and calculate permits, tablet_id=10128, compaction_type=2, permit=0, current_permit=0, status=prepare compaction with err: -2000
```
This PR change the log in this case more friendly.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhannngchen commented on a diff in pull request #8903: [improvement](log) make compaction no suitable version log more friendly
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #8903:
URL: https://github.com/apache/incubator-doris/pull/8903#discussion_r845695732
##########
be/src/olap/olap_server.cpp:
##########
@@ -399,8 +399,16 @@ void StorageEngine::_compaction_tasks_producer_callback() {
for (const auto& tablet : tablets_compaction) {
Status st = _submit_compaction_task(tablet, compaction_type);
if (!st.ok()) {
- LOG(WARNING) << "failed to submit compaction task for tablet: " << tablet->tablet_id()
- << ", err: " << st.get_error_msg();
+ if (st.precise_code() == OLAP_ERR_BE_NO_SUITABLE_VERSION ||
+ st.precise_code() == OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION) {
+ LOG(INFO) << "no suitable version for "
Review Comment:
Got it, I'll close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhannngchen closed pull request #8903: [improvement](log) make compaction no suitable version log more friendly
Posted by GitBox <gi...@apache.org>.
zhannngchen closed pull request #8903: [improvement](log) make compaction no suitable version log more friendly
URL: https://github.com/apache/incubator-doris/pull/8903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #8903: [improvement](log) make compaction no suitable version log more friendly
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #8903:
URL: https://github.com/apache/incubator-doris/pull/8903#discussion_r845127727
##########
be/src/olap/olap_server.cpp:
##########
@@ -399,8 +399,16 @@ void StorageEngine::_compaction_tasks_producer_callback() {
for (const auto& tablet : tablets_compaction) {
Status st = _submit_compaction_task(tablet, compaction_type);
if (!st.ok()) {
- LOG(WARNING) << "failed to submit compaction task for tablet: " << tablet->tablet_id()
- << ", err: " << st.get_error_msg();
+ if (st.precise_code() == OLAP_ERR_BE_NO_SUITABLE_VERSION ||
+ st.precise_code() == OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION) {
+ LOG(INFO) << "no suitable version for "
Review Comment:
There will still be a lot of LOG in be.INFO.
I modified this in #8887, FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org