You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "PhVHoang (via GitHub)" <gi...@apache.org> on 2024/02/21 13:37:27 UTC

[PR] Datafusion proto copy to partition by [arrow-datafusion]

PhVHoang opened a new pull request, #9306:
URL: https://github.com/apache/arrow-datafusion/pull/9306

   ## Which issue does this PR close?
   Closes #9248
   
   ## Rationale for this change
   
   Support serialization/deserialization `CopyTo::partition_by` in datafusion proto
   
   ## What changes are included in this PR?
   
   Code, tests
   
   ## Are these changes tested?
   Yes
   
   ## Are there any user-facing changes?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support CopyTo::partition_by in datafusion proto [arrow-datafusion]

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #9306:
URL: https://github.com/apache/arrow-datafusion/pull/9306


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support CopyTo::partition_by in datafusion proto [arrow-datafusion]

Posted by "devinjdangelo (via GitHub)" <gi...@apache.org>.
devinjdangelo commented on code in PR #9306:
URL: https://github.com/apache/arrow-datafusion/pull/9306#discussion_r1497637829


##########
datafusion/expr/src/logical_plan/dml.rs:
##########
@@ -36,7 +36,7 @@ pub struct CopyTo {
     pub output_url: String,
     /// The file format to output (explicitly defined or inferred from file extension)
     pub file_format: FileType,
-    /// Detmines which, if any, columns should be used for hive-style partitioned writes
+    /// Determines which, if any, columns should be used for hive-style partitioned writes

Review Comment:
   Thank you for catching this typo 😅



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support CopyTo::partition_by in datafusion proto [arrow-datafusion]

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #9306:
URL: https://github.com/apache/arrow-datafusion/pull/9306#issuecomment-1962943556

   Thanks @PhVHoang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org